Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

fix: update doc #185

Merged
merged 4 commits into from
Jul 1, 2024
Merged

fix: update doc #185

merged 4 commits into from
Jul 1, 2024

Conversation

chuang8511
Copy link
Member

Because

  • email should be email rather than gmail
  • the doc is outdated

This commit

  • change title
  • update the doc

Copy link

linear bot commented Jun 28, 2024

@chuang8511 chuang8511 changed the title Chunhao/ins 5108 fix: update doc Jun 28, 2024
@chuang8511 chuang8511 marked this pull request as ready for review June 28, 2024 11:12
@@ -310,10 +310,3 @@ Generate image from input text prompt and image.
| Output | ID | Type | Description |
| :--- | :--- | :--- | :--- |
| Images | `images` | array[string] | Images |

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fetch the latest compogen. These newlines are produced by changes in the compogen template to improve its readability (we don't care about readability in README.mdx, only on its HTML version, which removes redundant spaces.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvallesm
I did fetch the latest compogen.
But, it seems conflict with pre-commit hook now.
When I commit, those redundant lines are delete by pre-commit hook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one should we follow now?

Copy link
Member

@donch1989 donch1989 Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuang8511 @jvallesm
I add a rule to exclude the pre-commit-hooks for mdx files.

Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides minor comment

@donch1989 donch1989 merged commit 6e6639a into main Jul 1, 2024
8 checks passed
@donch1989 donch1989 deleted the chunhao/ins-5108 branch July 1, 2024 02:10
donch1989 pushed a commit that referenced this pull request Jul 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.21.0-beta](v0.20.2-beta...v0.21.0-beta)
(2024-07-02)


### Features

* add mail component
([#178](#178))
([04b19d0](04b19d0))
* add read task for gcs
([#155](#155))
([77fe2fc](77fe2fc))
* add read task in bigquery component
([#156](#156))
([4d2e7ec](4d2e7ec))
* **anthropic:** add Anthropic component
([#176](#176))
([030881d](030881d))
* **anthropic:** add UsageHandler functions in anthropic
([#186](#186))
([ebaa61f](ebaa61f))
* **compogen:** add extra section with --extraContents flag'
([#171](#171))
([391bb98](391bb98))
* **instill:** remove extra-params field
([#188](#188))
([b17ff73](b17ff73))
* **redis:** simplify the TLS configuration
([#194](#194))
([0a8baf7](0a8baf7))


### Bug Fixes

* **all:** fix typos
([#174](#174))
([cb3c2fb](cb3c2fb))
* **compogen:** wrong bracket direction in substitution
([#184](#184))
([dfe8306](dfe8306))
* expose input and output for anthropic for instill credit
([#190](#190))
([a36e876](a36e876))
* update doc
([#185](#185))
([6e6639a](6e6639a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
namwoam pushed a commit to namwoam/component that referenced this pull request Jul 8, 2024
Because

- email should be email rather than gmail
- the doc is outdated

This commit

- change title
- update the doc

---------

Co-authored-by: Chang, Hui-Tang <huitang.chang@instill.tech>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

4 participants