Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove name sorting option and fix asc/desc in sorting #1179

Merged
merged 3 commits into from
May 28, 2024
Merged

feat: remove name sorting option and fix asc/desc in sorting #1179

merged 3 commits into from
May 28, 2024

Conversation

thewbuk
Copy link
Contributor

@thewbuk thewbuk commented May 24, 2024 •
edited
Loading

Because

  • Remove name sort option
  • Choosing Ascending sends Descending to the backend and vice versa. This is a workaround to be discussed

@linear Linear
Copy link

linear bot commented May 24, 2024

INS-4731 [Bug] Hub sorting dropdown doesn't work correctly

@github-actions GitHub Actions
Copy link

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@EiffelFly
Copy link
Member

@thewbuk Please take a look the c3b59cb

The key takeaways are

  • The react-query has its own internal update cycle, in your previous implementation, the refetch and the update state pattern are in the same cycle, thus your refetch is still using the previous cycle's state. So the error happened
  • To correctly control the react-query cache, you need to use the queryKey to control it.

@EiffelFly EiffelFly self-assigned this May 28, 2024
@EiffelFly EiffelFly marked this pull request as ready for review May 28, 2024 08:38
@github-actions GitHub Actions
Copy link

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

EiffelFly
EiffelFly approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@EiffelFly EiffelFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EiffelFly EiffelFly merged commit 1cf38ae into main May 28, 2024
8 checks passed
@EiffelFly EiffelFly deleted the wojciech/ins-4731-bug-hub-sorting-dropdown-doesnt-work-correctly branch May 28, 2024 08:59
@droplet-bot droplet-bot mentioned this pull request May 24, 2024
Merged
EiffelFly pushed a commit that referenced this pull request May 28, 2024
@droplet-bot
chore: release main (#1181)
09c9ac3 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.47.2-beta</summary>

##
[0.47.2-beta](v0.47.1-beta...v0.47.2-beta)
(2024-05-28)


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
</details>

<details><summary>@instill-ai/design-system: 0.69.2</summary>

##
[0.69.2](https://github.com/instill-ai/console/compare/@instill-ai/design-system-v0.69.1...@instill-ai/design-system-v0.69.2)
(2024-05-28)


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
</details>

<details><summary>@instill-ai/design-tokens: 0.5.4</summary>

##
[0.5.4](https://github.com/instill-ai/console/compare/@instill-ai/design-tokens-v0.5.3...@instill-ai/design-tokens-v0.5.4)
(2024-05-28)


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
</details>

<details><summary>@instill-ai/toolkit: 0.92.0</summary>

##
[0.92.0](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.91.4...@instill-ai/toolkit-v0.92.0)
(2024-05-28)


### Features

* **auto-gen-form:** accept image field in the auto-gen-form
([#1182](#1182))
([121c570](121c570))
* remove name sorting option and fix asc/desc in sorting
([#1179](#1179))
([1cf38ae](1cf38ae))


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
* **organization:** update UploadAvatarFieldWithCrop component to accept
title props ([#1176](#1176))
([940ec3a](940ec3a))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
EiffelFly added a commit that referenced this pull request May 29, 2024
@thewbuk @EiffelFly
feat: remove name sorting option and fix asc/desc in sorting (#1179)
4194f4e 
Because
- Remove name sort option
- Choosing Ascending sends Descending to the backend and vice versa.
This is a workaround to be discussed

---------

Co-authored-by: EiffelFly <57251712+EiffelFly@users.noreply.github.com>
EiffelFly pushed a commit that referenced this pull request May 29, 2024
@droplet-bot @EiffelFly
chore: release main (#1181)
35c72fc 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.47.2-beta</summary>

##
[0.47.2-beta](v0.47.1-beta...v0.47.2-beta)
(2024-05-28)


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
</details>

<details><summary>@instill-ai/design-system: 0.69.2</summary>

##
[0.69.2](https://github.com/instill-ai/console/compare/@instill-ai/design-system-v0.69.1...@instill-ai/design-system-v0.69.2)
(2024-05-28)


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
</details>

<details><summary>@instill-ai/design-tokens: 0.5.4</summary>

##
[0.5.4](https://github.com/instill-ai/console/compare/@instill-ai/design-tokens-v0.5.3...@instill-ai/design-tokens-v0.5.4)
(2024-05-28)


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
</details>

<details><summary>@instill-ai/toolkit: 0.92.0</summary>

##
[0.92.0](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.91.4...@instill-ai/toolkit-v0.92.0)
(2024-05-28)


### Features

* **auto-gen-form:** accept image field in the auto-gen-form
([#1182](#1182))
([121c570](121c570))
* remove name sorting option and fix asc/desc in sorting
([#1179](#1179))
([1cf38ae](1cf38ae))


### Bug Fixes

* fix deps alerts and zod denial issue
([#1184](#1184))
([3db9a78](3db9a78))
* **organization:** update UploadAvatarFieldWithCrop component to accept
title props ([#1176](#1176))
([940ec3a](940ec3a))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EiffelFly EiffelFly EiffelFly approved these changes

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees

@EiffelFly EiffelFly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thewbuk @EiffelFly