Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: follow buf rule and style guidelines #34

Merged
merged 10 commits into from
Mar 15, 2022
Merged

refactor: follow buf rule and style guidelines #34

merged 10 commits into from
Mar 15, 2022

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Mar 11, 2022

Because

  • buf provides best practices and buf lint to strictly check rules and style in protobuf
  • content of protobufs should be consistent

This commit

@pinglin pinglin added enhancement New feature or request next-release labels Mar 11, 2022
@pinglin pinglin requested a review from Phelan164 March 13, 2022 00:43
@pinglin pinglin force-pushed the refactor branch 2 times, most recently from 1420fc3 to 1f0a773 Compare March 15, 2022 04:55
@pinglin pinglin requested a review from Phelan164 March 15, 2022 04:56
@pinglin pinglin requested a review from Phelan164 March 15, 2022 09:43
@pinglin pinglin force-pushed the refactor branch 2 times, most recently from 4319bb3 to 208ebb2 Compare March 15, 2022 10:16
@pinglin pinglin changed the title refactor: follow buf rule and style guidelines (WIP) refactor: follow buf rule and style guidelines Mar 15, 2022
Phelan164
Phelan164 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@Phelan164 Phelan164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit 18ecd40 into main Mar 15, 2022
@pinglin pinglin deleted the refactor branch March 15, 2022 10:42
@xiaofei-du xiaofei-du mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phelan164 Phelan164 Phelan164 approved these changes

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request next-release
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow the buf rules and categories guideline
2 participants
@pinglin @Phelan164