Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS.md: sync from the github API #201

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

russellb
Copy link
Member

Signed-off-by: Russell Bryant rbryant@redhat.com

@russellb russellb requested a review from a team as a code owner April 24, 2024 14:30
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get @mmcelaney in here as well so we can close #200

@mmcelaney which team are you supposed to be on? have you been added to the correct GitHub Team? once that's done we can follow the correct process here

@russellb
Copy link
Member Author

LGTM, let's get @mmcelaney in here as well so we can close #200

@mmcelaney which team are you supposed to be on? have you been added to the correct GitHub Team? once that's done we can follow the correct process here

I think this PR is fine as-is, and the discrepancy should be handled as documented, but let's talk on slack for more

@russellb russellb merged commit 7b649e1 into instructlab:main Apr 24, 2024
1 check passed
@mmcelaney
Copy link
Contributor

Updated team appropriately. Guessing I'll get added on the next API sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants