Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue around the selected model silently changing on refresh or page change #79

Merged

Conversation

aevo98765
Copy link
Member

@aevo98765 aevo98765 commented Jul 16, 2024

A user selects the model they want to chat to. On a page refresh or change the system changes the model selected back to the Granite 7B model. I was using a different one and did not expect this behaviour and therefore the API calls to the chat server were incorrect.

To address this I have:

  1. Stopped the first model in the drop down list being selected by default on page load. The model selector now has no model selected.
  2. If a user tries to submit a query with no model selected then an error message appears to communicate this.
  3. When the user selects the model they desire the error message clears.

I have noticed that the empty prompt in a request is not communicated to the user. I will deal with this in -> #78

Fixes #53

…to the user if no model is selected

Signed-off-by: Ash Evans <ash.evans@ibm.com>
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @nerdalert PTAL

Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nerdalert nerdalert merged commit 0052207 into instructlab:main Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The chat 'Model Selector' defaults back to Granite-7b every time the page is refreshed
3 participants