Non-oai usage meta + non-oai client types #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a12fbd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying instructor-js with
|
| Latest commit: |
5a12fbd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37374d28.instructor-js.pages.dev |
| Branch Preview URL: | https://non-oai-usage.instructor-js.pages.dev |
jxnl
previously approved these changes
Jun 12, 2024
|
we should probably do a page on the _meta obj - the completed paths property, usage, etc.. ps this pr depends on me pushing up new polyglot v to use the non-beta tools - just have to test and cleanup a few things hack-dance/island-ai#60 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix client inference for non oai + check for usage for non-oai and non-readable
We were not passing through usage into meta for llm-polyglot/anthropic clients because the existing logic to do it checked explicitly for OAI clients + dependent on the response being a stream that could be .tee'd
This update does a similar "tee" for the iterable so we can read in parallel but doesn't have the same stream_options check so it will always run for any non-oai clients - if they don't provide usage it will just ignore.
Additionally, client inference has been updated slightly to get rid of the annoying non oai client type errors