Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers + prep #99

Merged
merged 5 commits into from
Feb 1, 2024
Merged

providers + prep #99

merged 5 commits into from
Feb 1, 2024

Conversation

roodboi
Copy link
Collaborator

@roodboi roodboi commented Feb 1, 2024

cleaning up some unused stuff and adding explicit support for non oai providers - in preparation for coming pr with multi tool call support

Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: a197132

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@instructor-ai/instructor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@roodboi roodboi changed the title cleaning up some unused stuff and adding explicit support for non oai… providers + prep Feb 1, 2024
@roodboi roodboi requested a review from jxnl February 1, 2024 02:37
Copy link
Collaborator

@jxnl jxnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cracked, beautiful, ship it

@roodboi roodboi merged commit c9ab910 into main Feb 1, 2024
1 check passed
@roodboi roodboi deleted the providers-and-clean branch February 1, 2024 04:07
@roodboi roodboi mentioned this pull request Feb 1, 2024
"gpt-3.5-turbo-1106",
"gpt-4-1106-preview",
"gpt-4-0125-preview",
"gpt-4-turbo-preview"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like this ever bite us in the ass?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like every once in a while a new model comes out and then llama index or lane chain will break because they're using a literal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants