Fix long lines not working over stdin #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethr
approved these changes
Apr 29, 2020
|
If you could rebase against the latest master that would be appreciated. Otherwise looks good. |
carlpett
force-pushed
the
fix-long-stdin
branch
from
02da9bd
to
2b8681a
Compare
|
@garethr Done! Thanks for the review |
This was referenced Aug 9, 2020
This was referenced Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, piping a manifest with very long lines subtly breaks kubeval. The
bufio.Scannerused is not checked for errors after use, and for lines longer than 64k (https://github.com/golang/go/blob/go1.14/src/bufio/scan.go#L79) this means missing anErrTooLong. Since the error is never checked, kubeval assumes the full input has been read, and validates whatever it managed to read.We ran into this because of a ConfigMap with a
binaryDatasegment of a couple hundred kilobytes.This PR removes the Scanner and just uses
io.Copyinstead.ping @garethr