Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADM device switch races #151

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Fix ADM device switch races #151

merged 4 commits into from
Mar 4, 2024

Conversation

alexlapa
Copy link

@alexlapa alexlapa commented Mar 1, 2024

Synopsis

Currently there is some data races in ADM implementation.

Switching output devices might cause playout thread to stop scheduling playout tasks. Switching input devices might cause device failure.

Solution

Fix playout task not being rescheduled sometimes: 1, 2.

Fix recording devices restart, and increase recording failure detection window.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@alexlapa alexlapa self-assigned this Mar 1, 2024
@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::windows Specific to Windows platform platform::macos Specific to macOS platform platform::linux Specific to Linux platform labels Mar 1, 2024
@alexlapa
Copy link
Author

alexlapa commented Mar 1, 2024

FCM:

Fix race in I/O audio device switching on desktop (#151)

@alexlapa alexlapa requested a review from evdokimovs March 1, 2024 13:40
@alexlapa alexlapa marked this pull request as ready for review March 1, 2024 14:02
@evdokimovs evdokimovs requested a review from tyranron March 1, 2024 15:47
@tyranron tyranron merged commit 6ac5181 into main Mar 4, 2024
22 checks passed
@tyranron tyranron deleted the fix-adm-races branch March 4, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::windows Specific to Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants