Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggle send/recv transceiver direction #73

Merged
merged 17 commits into from
Jun 30, 2022
Merged

Add toggle send/recv transceiver direction #73

merged 17 commits into from
Jun 30, 2022

Conversation

rogurotus
Copy link

@rogurotus rogurotus commented Jun 24, 2022 •
edited by tyranron
Loading

Synopsis

This PR provides api toggle send/recv transceiver direction.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus added k::api Related to API (application interface) platform::windows Specific to Windows platform plarform::android Specific to Android platform platform::linux Specific to Linux platform feature New feature or request labels Jun 24, 2022
@rogurotus rogurotus requested a review from alexlapa June 24, 2022 16:40
@rogurotus rogurotus self-assigned this Jun 24, 2022
@rogurotus
Copy link
Author

rogurotus commented Jun 27, 2022 •
edited by alexlapa
Loading

FCM:

Add `set_transceiver_recv` and `set_transceiver_send` functions (#73)

@rogurotus rogurotus marked this pull request as ready for review June 27, 2022 11:46
@alexlapa alexlapa requested review from tyranron and removed request for tyranron June 29, 2022 12:02
@alexlapa alexlapa requested a review from tyranron June 29, 2022 12:56
tyranron
tyranron approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCM

Provide atomic `RtpTransceiver.setRecv()` and `RtpTransceiver.setSend()` methods (#73)

@tyranron tyranron enabled auto-merge (squash) June 30, 2022 14:48
@tyranron tyranron disabled auto-merge June 30, 2022 14:56
@tyranron tyranron enabled auto-merge (squash) June 30, 2022 15:06
@tyranron tyranron merged commit 3d09089 into master Jun 30, 2022
@tyranron tyranron deleted the add-toggler-send-recv-direction branch June 30, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@rogurotus rogurotus

Labels
feature New feature or request k::api Related to API (application interface) plarform::android Specific to Android platform platform::linux Specific to Linux platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogurotus @tyranron @alexlapa