Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MediaManager.on_device_change callback #30

Merged
merged 16 commits into from
Mar 16, 2022
Merged

Add MediaManager.on_device_change callback #30

merged 16 commits into from
Mar 16, 2022

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Mar 9, 2022 •
edited by tyranron

Synopsis

Этот PR добавляет коллбэк (MediaManager.on_device_change), который будет выстреливать при изменении списка девайсов (MediaDevice.enumerateDevices).

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed
    • flutter-webrtc dependency switched back to master branch

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) platform::android Specific to Android platform platform::web Specific to WEB platform labels Mar 9, 2022
@evdokimovs evdokimovs self-assigned this Mar 9, 2022
evdokimovs and others added 5 commits March 9, 2022 19:39
@evdokimovs
Fix CI
2172304
@alexlapa
Merge branch 'master' into on-device-change-callback
e558e95
@alexlapa
corrections
9daa89d
@evdokimovs
Merge branch 'master' into on-device-change-callback
2897930 
# Conflicts:
#	CHANGELOG.md
#	flutter/android/src/main/jniLibs/arm64-v8a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/armeabi-v7a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86_64/libmedea_jason.so
#	flutter/assets/pkg/medea_jason.js
#	flutter/lib/src/interface/media_device_info.dart
#	flutter/lib/src/interface/media_manager.dart
#	flutter/lib/src/native/media_manager.dart
#	flutter/lib/src/native/platform/media_devices.dart
#	flutter/lib/src/native/platform/media_devices.g.dart
#	flutter/lib/src/web/media_manager.dart
#	src/api/dart/media_manager_handle.rs
#	src/api/dart/utils/err.rs
#	src/api/err.rs
#	src/api/wasm/mod.rs
#	src/media/manager.rs
#	src/media/mod.rs
#	src/platform/dart/media_devices.rs
#	src/platform/dart/mod.rs
#	src/platform/wasm/media_device_info.rs
#	src/platform/wasm/media_devices.rs
#	src/platform/wasm/mod.rs
@evdokimovs
Fix merge, refactor
47f6775
@evdokimovs evdokimovs marked this pull request as ready for review March 14, 2022 15:36
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Mar 14, 2022 •
edited by tyranron

FCM

Provide `MediaManager::on_device_change()` callback (#30)

@alexlapa alexlapa requested a review from tyranron March 15, 2022 11:08
@tyranron tyranron changed the title Draft: Add MediaManager.on_device_change callback Add MediaManager.on_device_change callback Mar 15, 2022
@evdokimovs evdokimovs merged commit 3c6690e into master Mar 16, 2022
@evdokimovs evdokimovs deleted the on-device-change-callback branch March 16, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface) platform::android Specific to Android platform platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evdokimovs @tyranron @alexlapa