Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Rust to JS error propagation #4

Merged
merged 21 commits into from
Oct 1, 2021
Merged

Refactor Rust to JS error propagation #4

merged 21 commits into from
Oct 1, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Sep 27, 2021 •
edited by tyranron

Synopsis

PR which refactors error propagation from Rust to JS. Now, instead of propagating generic JasonError, we will propagate object representing exact error type.

Solution

  1. Get rid of JasonError
  2. Propagate exception of the exact type instead of JasonError

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::design Related to overall design and/or architecture labels Sep 27, 2021
@evdokimovs evdokimovs self-assigned this Sep 27, 2021
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Sep 28, 2021 •
edited by tyranron

FCM

Refactor Rust to JS error propagation (#4)

- remove `JasonError`
- throw errors of the concrete types from WASM Jason
- refactor `JsCaused` to `Caused`

Additionally:
- upgrade Firefox to 92.0 version for E2E tests
- upgrade Chrome to 94.0 version for E2E tests
- upgrade Flutter to 2.5.1 version for instrumented tests

@evdokimovs evdokimovs marked this pull request as ready for review September 28, 2021 15:12
@alexlapa
Copy link
Contributor

@evdokimovs ,

Все ок, только е2е тесты падают, гляньте в чем дело. Возможно, виноват токио 1.12.
https://github.com/instrumentisto/medea-jason/runs/3753632006

@evdokimovs
Copy link
Contributor Author

@alexlapa ,

только е2е тесты падают

В tokio_macro v1.4.1 эти изменения уже откатили. tokio-rs/tokio#4140

@tyranron tyranron changed the title Draft: Refactor Rust to JS error propagation Refactor Rust to JS error propagation Oct 1, 2021
@evdokimovs evdokimovs merged commit f29f3a8 into master Oct 1, 2021
@evdokimovs evdokimovs deleted the refactor-rust-to-js-err-propagation branch October 1, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evdokimovs @alexlapa @tyranron