-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Rust to JS error propagation #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdokimovs
added
enhancement
Improvement of existing features or bugfix
k::api
Related to API (application interface)
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
k::design
Related to overall design and/or architecture
labels
Sep 27, 2021
FCM
|
Все ок, только е2е тесты падают, гляньте в чем дело. Возможно, виноват токио |
В |
alexlapa
approved these changes
Sep 30, 2021
tyranron
changed the title
Draft: Refactor Rust to JS error propagation
Refactor Rust to JS error propagation
Oct 1, 2021
tyranron
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
PR which refactors error propagation from Rust to JS. Now, instead of propagating generic JasonError, we will propagate object representing exact error type.
Solution
JasonError
JasonError
Checklist
Draft:
prefixk::
labels appliedDraft:
prefix is removed