Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flutter desktop support #45

Merged
merged 42 commits into from
Apr 19, 2022
Merged

Add flutter desktop support #45

merged 42 commits into from
Apr 19, 2022

Conversation

logist322
Copy link
Contributor

@logist322 logist322 commented Apr 11, 2022 •
edited by tyranron

Synopsis

Improve Jason for working under desktops too.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@logist322 logist322 self-assigned this Apr 11, 2022
@logist322 logist322 added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::windows Specific to Windows platform labels Apr 11, 2022
@logist322
Copy link
Contributor Author

logist322 commented Apr 11, 2022 •
edited by tyranron

FCM

Add Windows and Linux platforms support to `medea_jason` Flutter plugin (#45)

- fix Dart imports
- implement screen sharing for Dart platform

logist322 and others added 4 commits April 12, 2022 18:30
@logist322
Fix CI
ffb0e77
@alexlapa
corrections
8801e24
@alexlapa
Merge branch 'master' into for-social
424fcb5 
# Conflicts:
#	flutter/assets/pkg/medea_jason.js
#	flutter/assets/pkg/medea_jason_bg.wasm
#	flutter/windows/lib/x86_64-pc-windows-msvc/medea_jason.dll
@alexlapa
corrections
37671f1
@alexlapa alexlapa changed the title Add Windows support Add flutter desktop support Apr 18, 2022
@alexlapa alexlapa self-requested a review April 18, 2022 14:02
@alexlapa alexlapa marked this pull request as ready for review April 18, 2022 14:02
alexlapa
alexlapa reviewed Apr 19, 2022
View reviewed changes
.github/workflows/ci.yml Outdated
- platform: linux
os: ubuntu
# TODO: Flutter requires libc6 of 2.34 version for some reason.
# Uncomment when github will update ubuntu-latest to 22.04.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyranron ,

Новая LTS'ка через два дня выходит, до гитхаба тоже, думаю, скоро доедет.

@alexlapa alexlapa requested a review from tyranron April 19, 2022 10:17
tyranron
tyranron reviewed Apr 19, 2022
View reviewed changes
src/platform/dart/constraints.rs
let optional =
DartHandle::new(constraints::new_video_constraints());
let mandatory =
DartHandle::new(constraints::new_video_constraints());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK that we don't use from input value here at all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyranron ,

Угу, у нас в DisplayVideoTrackConstraints лежит только required: bool. Т.е. мы сейчас не поддерживаем никакие констрейнты на screen-captured видео треки.

@tyranron tyranron merged commit 064f6e8 into master Apr 19, 2022
@tyranron tyranron deleted the for-social branch April 19, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron left review comments

@alexlapa alexlapa alexlapa approved these changes

Assignees

@logist322 logist322

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@logist322 @tyranron @alexlapa @evdokimovs