Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getUserMedia error handling more detailed #52

Merged
merged 25 commits into from
May 11, 2022
Merged

Make getUserMedia error handling more detailed #52

merged 25 commits into from
May 11, 2022

Conversation

logist322
Copy link
Contributor

@logist322 logist322 commented May 3, 2022 •
edited by tyranron
Loading

Synopsis

This PR provides the ability to detaile the cause of error while calling getUserMedia.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@logist322 logist322 added feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture k::documentation Related to project documentation platform::android Specific to Android platform platform::ios Specific to iOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform labels May 3, 2022
@logist322 logist322 self-assigned this May 3, 2022
@logist322 logist322 changed the title Make getMedia error handling more detailed Make getUserMedia error handling more detailed May 4, 2022
@logist322
Copy link
Contributor Author

FCM

Provide more information about `InitLocalTracksError` errors (#52)

@logist322 logist322 requested a review from alexlapa May 10, 2022 09:45
@logist322 logist322 marked this pull request as ready for review May 10, 2022 09:45
@alexlapa alexlapa requested a review from tyranron May 11, 2022 07:01
@alexlapa alexlapa added enhancement Improvement of existing features or bugfix and removed platform::android Specific to Android platform platform::ios Specific to iOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform k::documentation Related to project documentation feature New feature or request labels May 11, 2022
@tyranron tyranron removed the k::design Related to overall design and/or architecture label May 11, 2022
@tyranron tyranron merged commit 9d42236 into master May 11, 2022
@tyranron tyranron deleted the fix-asrc branch May 11, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@logist322 logist322

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@logist322 @tyranron @alexlapa @evdokimovs