Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement error handling for Flutter Web #9

Merged
merged 60 commits into from
Oct 19, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Oct 8, 2021

Synopsis

Currently, exceptions thrown from the Jason are not usable, so we need to create wrappers for all Jason exceptions and rethrow JS exceptions as converted Dart exceptions.

Solution

  1. Add wrappers for all Jason error
  2. Implement convertes for the exceptions
  3. Re-throw JS exceptions as converted Dart exceptions

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture labels Oct 8, 2021
@alexlapa
Copy link
Contributor

@evdokimovs ,

Тут instrumented тестам опять плохо, гляньте что может быть. В остальном все ок.

@tyranron tyranron added enhancement Improvement of existing features or bugfix and removed k::design Related to overall design and/or architecture labels Oct 19, 2021
@tyranron tyranron changed the title Draft: Implement error handling for Flutter Web Implement error handling for Flutter Web Oct 19, 2021
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs please, regenerate assets/pkg/ files before merging this. Running make cargo.build.jason platform=web of latest wasm-pack on my side produces strangerly too huge diff, not only comments changes as intended. So, I should be missing something.

@evdokimovs evdokimovs merged commit 1586e89 into master Oct 19, 2021
@evdokimovs evdokimovs deleted the flutter-web-error-handling branch October 19, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) platform::web Specific to WEB platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants