Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added surelock laser module #144

Merged
merged 4 commits into from
Sep 8, 2016
Merged

added surelock laser module #144

merged 4 commits into from
Sep 8, 2016

Conversation

CatherineH
Copy link
Contributor

The Ondax Surelock Laser module has a communication protocol with few patterns, thus there is little to be gained other than confusion in using factory modules.

@coveralls
Copy link

coveralls commented Aug 20, 2016

Coverage Status

Coverage increased (+0.4%) to 84.418% when pulling 578976d on ch-ondax-rebase into 469dfe6 on develop.

@scasagrande scasagrande added this to the 0.3 milestone Aug 23, 2016

# INNER CLASSES #

class AutomaticCurrentControl(object):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes should probably be prefixed with an underscore so that users don't think they should be accessing it via LM.AutomaticCurrentControl

@scasagrande
Copy link
Contributor

A lot of these properties can be converted to using the property templates.

For inner classes, you can also use the property templates if you define dummy sendcmd and query functions within those inner classes like this:

def sendcmd(self, msg):
    self._parent.sendcmd(msg)

def query(self, msg, size=-1):
    return self._parent.query(msg, size)

This will then allow you to put upper and lower bounds on all the properties with setters.

@coveralls
Copy link

coveralls commented Aug 27, 2016

Coverage Status

Coverage increased (+0.4%) to 84.468% when pulling 1100d74 on ch-ondax-rebase into 469dfe6 on develop.

@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Coverage increased (+0.4%) to 84.431% when pulling 29a6213 on ch-ondax-rebase into 469dfe6 on develop.

@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Coverage increased (+0.5%) to 84.514% when pulling 074d72f on ch-ondax-rebase into 469dfe6 on develop.

@scasagrande
Copy link
Contributor

Note that one of the things I changed was some of the units you were using in time-based properties. There was a lot of pq.mS, which is not milliseconds, but millisiemens. I changed these all to pq.ms so your code might need to be changed accordingly.

@scasagrande
Copy link
Contributor

I'm going to assume my changes were okay. I might revisit some implementation details later, but I suppose we'll go with this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants