Create compiler to ship insulin.phar #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Compiles insulin into a single phar file. | ||
| * | ||
| * @param string $pharFile The full path to the file to create. |
There was a problem hiding this comment.
Why the extra space before string?
| * The phar to add files to. | ||
| * @param \SplFileInfo $file | ||
| * The file to add to phar archive. | ||
| * @param bool $strip |
There was a problem hiding this comment.
This should be marked as optional right?
Plus we should clearly state that by default true is used.
Similar to what we do on SugarInterface.
This reduces the amount of code to download for SugarCRM developers that won't work with our code (aka consumers only).
jcsmorais
added a commit
that referenced
this pull request
Feb 3, 2014
Create compiler to ship insulin.phar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of code to download for SugarCRM developers that
won't work with our code (aka consumers only).