Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memfile is hashed even if hashing and signing are disabled #6

Closed
Kiwii opened this issue May 28, 2021 · 2 comments
Closed

memfile is hashed even if hashing and signing are disabled #6

Kiwii opened this issue May 28, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Kiwii
Copy link

Kiwii commented May 28, 2021

--disable-hashing doesn't disable hashing; it just ignores a mismatch. I assume by design as the signature check also uses the new hash, but it could be skipped if signing is disabled as well.
@int-72h
Copy link
Owner

int-72h commented May 28, 2021

A bit of a misleading name then, I shoud call it "don't check hash"

@int-72h int-72h added the bug Something isn't working label May 28, 2021
@int-72h
Copy link
Owner

int-72h commented May 28, 2021

should be fixed in the next unstable commit

int-72h added a commit that referenced this issue Jun 2, 2021
@int-72h
basic error handing, also closes #6
eaf00c5
@int-72h int-72h closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kiwii @int-72h