Add Argo CD URL and external URL to Deployment #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
int128
force-pushed
the
add-url-to-deployment
branch
from
44e291c
to
10c2f44
Compare
This comment has been minimized.
This comment has been minimized.
int128
force-pushed
the
add-url-to-deployment
branch
from
10c2f44
to
bbee01c
Compare
This comment has been minimized.
This comment has been minimized.
int128
force-pushed
the
add-url-to-deployment
branch
from
bbee01c
to
f09e2f0
Compare
This comment has been minimized.
This comment has been minimized.
int128
force-pushed
the
add-url-to-deployment
branch
from
f09e2f0
to
3c84d4f
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 28, 2021
int128
force-pushed
the
add-url-to-deployment
branch
from
3c84d4f
to
cdc435b
Compare
diff
config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yamldiff --git a/tmp/kustomize-action-c6StfM/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml b/tmp/kustomize-action-ayPb98/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
index 463dd19..e6b996b 100644
--- a/tmp/kustomize-action-c6StfM/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
+++ b/tmp/kustomize-action-ayPb98/config/default/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
@@ -13,3 +13,11 @@ rules:
- list
- patch
- watch
+- apiGroups:
+ - ""
+ resources:
+ - configmaps
+ verbs:
+ - get
+ - list
+ - watche2e_test/argocd/v1_configmap_argocd-cm.yamldiff --git a/tmp/kustomize-action-c6StfM/e2e_test/argocd/v1_configmap_argocd-cm.yaml b/tmp/kustomize-action-ayPb98/e2e_test/argocd/v1_configmap_argocd-cm.yaml
index a64c676..18aa013 100644
--- a/tmp/kustomize-action-c6StfM/e2e_test/argocd/v1_configmap_argocd-cm.yaml
+++ b/tmp/kustomize-action-ayPb98/e2e_test/argocd/v1_configmap_argocd-cm.yaml
@@ -1,6 +1,7 @@
apiVersion: v1
data:
timeout.reconciliation: 10s
+ url: https://argocd.example.com
kind: ConfigMap
metadata:
labels:e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yamldiff --git a/tmp/kustomize-action-c6StfM/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml b/tmp/kustomize-action-ayPb98/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
index 463dd19..e6b996b 100644
--- a/tmp/kustomize-action-c6StfM/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
+++ b/tmp/kustomize-action-ayPb98/e2e_test/controller/rbac.authorization.k8s.io_v1_clusterrole_argocd-commenter-manager-role.yaml
@@ -13,3 +13,11 @@ rules:
- list
- patch
- watch
+- apiGroups:
+ - ""
+ resources:
+ - configmaps
+ verbs:
+ - get
+ - list
+ - watch |
This was referenced Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.