Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from kubebuilder v3.14.2 to v3.15.1 #262

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

int128
Copy link
Owner

@int128 int128 commented Jun 15, 2024

Copy link
Contributor

diff

  • config/default/apps_v1_deployment_ktunnels-controller-manager.yaml
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-metrics-reader.yaml (Deleted)
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-proxy-role.yaml (Deleted)
  • config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_ktunnels-proxy-rolebinding.yaml (Deleted)
  • config/default/v1_service_ktunnels-controller-manager-metrics-service.yaml (Deleted)

config/default/apps_v1_deployment_ktunnels-controller-manager.yaml

--- a/tmp/kustomize-action-XXXXXX3kvEg1/config/default/apps_v1_deployment_ktunnels-controller-manager.yaml
+++ b/tmp/kustomize-action-XXXXXXj5PKCx/config/default/apps_v1_deployment_ktunnels-controller-manager.yaml
@@ -21,32 +21,8 @@ spec:
     spec:
       containers:
       - args:
-        - --secure-listen-address=0.0.0.0:8443
-        - --upstream=http://127.0.0.1:8080/
-        - --logtostderr=true
-        - --v=0
-        image: gcr.io/kubebuilder/kube-rbac-proxy:v0.16.0
-        name: kube-rbac-proxy
-        ports:
-        - containerPort: 8443
-          name: https
-          protocol: TCP
-        resources:
-          limits:
-            cpu: 500m
-            memory: 128Mi
-          requests:
-            cpu: 5m
-            memory: 64Mi
-        securityContext:
-          allowPrivilegeEscalation: false
-          capabilities:
-            drop:
-            - ALL
-      - args:
-        - --health-probe-bind-address=:8081
-        - --metrics-bind-address=127.0.0.1:8080
         - --leader-elect
+        - --health-probe-bind-address=:8081
         command:
         - /manager
         image: controller:latest

config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-metrics-reader.yaml

--- a/tmp/kustomize-action-XXXXXX3kvEg1/config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-metrics-reader.yaml
+++ /dev/null
@@ -1,12 +0,0 @@
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRole
-metadata:
-  labels:
-    app.kubernetes.io/managed-by: kustomize
-    app.kubernetes.io/name: ktunnels
-  name: ktunnels-metrics-reader
-rules:
-- nonResourceURLs:
-  - /metrics
-  verbs:
-  - get

config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-proxy-role.yaml

--- a/tmp/kustomize-action-XXXXXX3kvEg1/config/default/rbac.authorization.k8s.io_v1_clusterrole_ktunnels-proxy-role.yaml
+++ /dev/null
@@ -1,20 +0,0 @@
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRole
-metadata:
-  labels:
-    app.kubernetes.io/managed-by: kustomize
-    app.kubernetes.io/name: ktunnels
-  name: ktunnels-proxy-role
-rules:
-- apiGroups:
-  - authentication.k8s.io
-  resources:
-  - tokenreviews
-  verbs:
-  - create
-- apiGroups:
-  - authorization.k8s.io
-  resources:
-  - subjectaccessreviews
-  verbs:
-  - create

config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_ktunnels-proxy-rolebinding.yaml

--- a/tmp/kustomize-action-XXXXXX3kvEg1/config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_ktunnels-proxy-rolebinding.yaml
+++ /dev/null
@@ -1,15 +0,0 @@
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRoleBinding
-metadata:
-  labels:
-    app.kubernetes.io/managed-by: kustomize
-    app.kubernetes.io/name: ktunnels
-  name: ktunnels-proxy-rolebinding
-roleRef:
-  apiGroup: rbac.authorization.k8s.io
-  kind: ClusterRole
-  name: ktunnels-proxy-role
-subjects:
-- kind: ServiceAccount
-  name: ktunnels-controller-manager
-  namespace: ktunnels-system

config/default/v1_service_ktunnels-controller-manager-metrics-service.yaml

--- a/tmp/kustomize-action-XXXXXX3kvEg1/config/default/v1_service_ktunnels-controller-manager-metrics-service.yaml
+++ /dev/null
@@ -1,17 +0,0 @@
-apiVersion: v1
-kind: Service
-metadata:
-  labels:
-    app.kubernetes.io/managed-by: kustomize
-    app.kubernetes.io/name: ktunnels
-    control-plane: controller-manager
-  name: ktunnels-controller-manager-metrics-service
-  namespace: ktunnels-system
-spec:
-  ports:
-  - name: https
-    port: 8443
-    protocol: TCP
-    targetPort: https
-  selector:
-    control-plane: controller-manager

See the workflow run

@int128 int128 merged commit eff551d into main Jun 15, 2024
7 checks passed
@int128 int128 deleted the upgrade-kubebuilder-v3.15.1 branch June 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant