Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial module #454

Merged
merged 21 commits into from
Mar 11, 2022
Merged

Add tutorial module #454

merged 21 commits into from
Mar 11, 2022

Conversation

jukent
Copy link
Collaborator

@jukent jukent commented Mar 11, 2022

Change Summary

Creates tutorial.py module to get the URL for catalogues to be used in tutorial examples and easily accessible for new learners.

Updates init.py to access the load_catalogue fx

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

Documentation will be updated to make use of this new URL access.

@jukent
Copy link
Collaborator Author

jukent commented Mar 11, 2022

I wish I understood Pytest more. This is my attempt at using pytest.mark.parametrize as best as I can gather from the docs. I think I need to be done for today, but any help is appreciated!

NOTE: The URL the data points to will not exist until after the merge. Could that contribute to failing tests? (Not the immediate ones, as those are KeyErrors)

@jukent jukent added documentation Documentation related enhancement Issues that are found to be a reasonable candidate feature additions labels Mar 11, 2022
@jukent
Copy link
Collaborator Author

jukent commented Mar 11, 2022

The tests are failing now with a "FileNotFoundError: https://raw.githubusercontent.com/intake/intake-esm/main/tutorial-catalogs/GOOGLE-CMIP6.json" which is a file that WILL exist... after the merge. What is the best approach to this? @andersy005

@jukent jukent marked this pull request as ready for review March 11, 2022 16:42
@jukent jukent requested a review from andersy005 as a code owner March 11, 2022 16:42
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jukent! This looks great

@andersy005 andersy005 changed the title Tutorial URL module Add tutorial module Mar 11, 2022
@andersy005 andersy005 merged commit 2deb41c into intake:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related enhancement Issues that are found to be a reasonable candidate feature additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Intake-ESM test data for download
2 participants