Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create GUI instance rather than CatalogGUI #716

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

AlbertDeFusco
Copy link
Contributor

@AlbertDeFusco AlbertDeFusco commented Mar 1, 2023

This addresses #714 . The CatalogGUI instance does not work well if there are nested catalogs. Here's an example catalog.yaml file

name: my_local_catalog
sources:
    df:
      driver: csv
      args:
        urlpath: https://bit.ly/autompg-csv
    weather:
        driver: yaml_file_cat
        args:
            path: https://gist.githubusercontent.com/AlbertDeFusco/60a3d2031f89f1fed1d396bb367fe168/raw/401b29419608abd51985f45a81308bc3f4534410/weather.yaml

I've included a short screen capture to demonstrate what this change enables. You'll notice df in the list of sources in the root of the catalog and the nested weather catalog.

ScreenFlow

A CatalogGUI instance does not work well
if there are nested catalogs
@martindurant
Copy link
Member

https://intake.readthedocs.io/en/latest/gui.html doesn't mention the old version of this, which didn't work for you - so good!

@martindurant martindurant merged commit 1e26dc1 into intake:master Mar 1, 2023
@sophiamyang
Copy link
Contributor

Hi @AlbertDeFusco, @martindurant mentioned that the GUI should look differently for intake 0.6.8? I don't think I see the updated GUI yet : )
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants