Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojibake in notifications #1416

Closed
shogo82148 opened this issue Jun 20, 2022 · 6 comments
Closed

Mojibake in notifications #1416

shogo82148 opened this issue Jun 20, 2022 · 6 comments
Assignees
Labels

Comments

@shogo82148
Copy link

shogo82148 commented Jun 20, 2022

Describe the bug

I got Mojibake on notifications from 2022-06-20 10:42 UTC

To Reproduce
Steps to reproduce the behavior:

  1. Go to a channel on Slack
  2. Enter /github subscribe shogo82148/psychic-tribble to subscribe notifications
  3. Go to the new issue page e.g. https://github.com/shogo82148/psychic-tribble/issues/new
  4. Enter "こんにちは世界" into the title
  5. Click on "Submit new issue"
  6. Go to the channel and see the notification message

Expected behavior

I wanted "こんにちは世界" on the notification, however I got "ããã«ã¡ã¯ä¸ç".

Screenshots

The issue on GitHub:

image

The notification on Slack:

Notification on Slack

Desktop (please complete the following information):

  • OS: macOS Monterey
  • Browser: Firefox
  • Version: 101.0.1

Smartphone (please complete the following information):

N/A

Additional context

N/A

@techinpark
Copy link

same issue in korean

@andelf
Copy link

andelf commented Jun 21, 2022

Same issue in Simplified Chinese.

@ka2n
Copy link

ka2n commented Jun 21, 2022

it seems like:

>>> u"こんにちは世界".encode('utf-8').decode('latin-1')
\x81\x93ã\x82\x93ã\x81«ã\x81¡ã\x81¯ä¸\x96ç\x95\x8c'

@anuraag016
Copy link

anuraag016 commented Jun 21, 2022

This had happened due to a regression in the code, the encoding was inadvertently changed from UTF-8 to binary causing this issue. We have fixed the issue and deployed the change.

@ynishi2014
Copy link

This issue has fixed for us. Thanks.

@shogo82148
Copy link
Author

It looks to be fine. Thank you for quick fix!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants