Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format option to subscriptions to only show condensed notification messages #1046

Closed
wants to merge 2 commits into from

Conversation

ryamaguchi0220
Copy link

@ryamaguchi0220 ryamaguchi0220 commented Jul 7, 2020

Close #162

This PR adds format option to subscriptions to only show condensed notification messages.

Usage

/github subscribe owner/repo format=[full|condensed]

The value can be one of:

  • full - Full version message (default)
  • condensed - Condensed version message

@welcome
Copy link

welcome bot commented Jul 7, 2020

Thanks for taking time to contribute! We'll check this out soon and let you know if we have any questions or feedback.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1046 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
+ Coverage   97.01%   97.03%   +0.01%     
==========================================
  Files         157      157              
  Lines        2649     2663      +14     
  Branches      362      364       +2     
==========================================
+ Hits         2570     2584      +14     
  Misses         75       75              
  Partials        4        4              

@ryamaguchi0220 ryamaguchi0220 changed the title Add a format option to subscriptions to only show condensed notification messages Add format option to subscriptions to only show condensed notification messages Jul 7, 2020
@JoannaFalkowska
Copy link

Would it be possible to also add the formatting option to the regular messages' previews using this, or is that a completely different thing?

@ryamaguchi0220
Copy link
Author

ryamaguchi0220 commented Jul 10, 2020

No, it's not possible. This format option affects only notifications from issue:opened and pr:opened events.
For that functionality, I think it's needed to add a new command to configure and save format settings for each Slack channels not subscriptions.

@joeydong
Copy link

what are we waiting on to get this merged? strongly looking forward to this feature!

@philjb
Copy link

philjb commented Oct 15, 2020

@wilhelmklopp - Any chance you could help move this forward?

@ryamaguchi0220 - could you add a before and after screenshot so we can see what the condensed version looks like?

@wilhelmklopp
Copy link
Contributor

Hey! I'm no longer working on this project, but @tebriel may be able to help 🙂

@ryamaguchi0220
Copy link
Author

ryamaguchi0220 commented Oct 17, 2020

Hi,

could you add a before and after screenshot so we can see what the condensed version looks like?

Actually, I added test code as much as I can but, it has not been tested on Slack yet because I could not build my testing environment well (followed this guide). I'm sorry but could anyone test it on Slack and add the screenshots instead of me?

@Mortefal
Copy link

any update on this? 💯

@aukobara
Copy link

aukobara commented Nov 2, 2020

@tebriel are there any plans to merge this? folks in my team already hate me for my decision to add github bot to our channel due to all this spam. still promising them to do something with that. but their patience cannot long forever 8)

@tebriel
Copy link
Contributor

tebriel commented Nov 2, 2020

@aukobara I'm no longer on the team at GitHub that maintains the Slack Integration, the new team is spinning up and is aware of the backlog of features on this repo. 🤞🏻 that they can assist soon!

@krambertech
Copy link

krambertech commented Dec 2, 2020

Is there any way we could help in moving this forward? 🙏
Our team was forced to downgrade to Zapier because of a large size of PR notifications, but would really love to use github's integration instead.

@ashokirla
Copy link
Contributor

@ryamaguchi0220 Thanks for this PR. We have recently taken ownership of Slack app and we are currently not taking any PRs as we are working on platform level improvements.

We will move this to PR to Issue and and take it up as a feature request.

Thanks for your support.

@ryamaguchi0220
Copy link
Author

@ashokirla I respect your decision. I just think that it might be a good idea for you to work on #1127 as soon as possible.

@ashokirla
Copy link
Contributor

Closing this PR and moving it to issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration: condensed attachments for subscriptions