Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4 pull-requests: community standards, donate, deploy with ci/cd and website for docs, faq or tutorials #13

Merged
merged 27 commits into from May 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 31, 2023

Hello everyone!

Intro

I would like to contribute to this pull-request and I hope you all accept it. So, things I added:

  • CODE_OF_CONDUCT.md
  • CONTRIBUTING.md
  • Issue/pull-request template
  • deploy with ci/cd bere: appveyor.yml
  • donate here: FUNDING.yml
  • github-pages for docs with static.yml

demo here: img-1
image

demo here: img-2
image

pull-request-1

I added files in markdown that make up a community standards area. You can see the before and after. These files serve to guide people who want to develop things for Foton. This pull-request-1 composes: CODE_OF_CONDUCT.md CONTRIBUTING.md, Issue/pull-request template in folder called: .github.

img-before
image

img-after
image

pull-request-2

Here I added a responsible file to add financial support in the open project: foton. You can see the before and after. This pull-request-2 composes: FUNDING.yml in folder called: .github.

img-before
image

img-after
image

pull-request-3

Now it will be possible to automate all tests and builds of the library in C# Foton. You can test the library on different operating systems in the cloud with AppVeyor. AppVeyor has a free plan for open projects. AppVeyor is Continuous Integration(CI) and Deployment (CD) service.

pull-request-4

I added in the pull-request here a static file to generate a website with docsify, github pages, markdown for docs. Please, see this: https://cliffbellman-dev.github.io/foton/#/. What I'm sending here might be something like: https://integrativesoft.github.io/foton/#/.

@ghost ghost changed the title add community standards add community standards (CODE_OF_CONDUCT, CONTRIBUTING, Issue/pull-request template) Mar 31, 2023
@ghost ghost changed the title add community standards (CODE_OF_CONDUCT, CONTRIBUTING, Issue/pull-request template) add community standards (CODE_OF_CONDUCT, CONTRIBUTING, Issue/pull-request template), donate and deploy in appveyor Mar 31, 2023
@ghost ghost changed the title add community standards (CODE_OF_CONDUCT, CONTRIBUTING, Issue/pull-request template), donate and deploy in appveyor add community standards, donate and deploy Mar 31, 2023
@ghost ghost changed the title add community standards, donate and deploy add community standards, donate and deploy with ci/cd Mar 31, 2023
@ghost ghost mentioned this pull request Mar 31, 2023
@ghost ghost changed the title add community standards, donate and deploy with ci/cd add community standards, donate, deploy with ci/cd and website for docs Mar 31, 2023
@ghost ghost changed the title add community standards, donate, deploy with ci/cd and website for docs add community standards, donate, deploy with ci/cd and website for docs or faq Mar 31, 2023
@ghost ghost changed the title add community standards, donate, deploy with ci/cd and website for docs or faq add 4 pull-requests: community standards, donate, deploy with ci/cd and website for docs or faq Mar 31, 2023
@ghost ghost changed the title add 4 pull-requests: community standards, donate, deploy with ci/cd and website for docs or faq add 4 pull-requests: community standards, donate, deploy with ci/cd and website for docs, faq or tutorials Mar 31, 2023
Copy link
Member

@pablocar80 pablocar80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments, thank you

docs/README.md Outdated
<img src="https://img.shields.io/badge/License-Apache%202.0-blue.svg" alt="Foton is licensed with Apache License 2.0">
</a>
<a href="https://www.repostatus.org/#active">
<img src="https://www.repostatus.org/badges/latest/active.svg" alt="Project Status: Active – The project has reached a stable, usable state and is being actively developed."/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn’t say it’s stable/usable yet, still experimental

Copy link

@ghost ghost Apr 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi pablocar80, change made.
image

docs/README.md Outdated
Foton is prototype for an Electron alternative written in C# by Integrative Software LLC and contributors.

## Quick start
First, download and install C# in Visual Studio - last version is required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode should be an option too

Copy link

@ghost ghost Apr 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi pablocar80, change made too.
image

README.md Outdated
<a href="https://www.repostatus.org/#active">
<img src="https://www.repostatus.org/badges/latest/active.svg" alt="Project Status: Active – The project has reached a stable, usable state and is being actively developed."/>
<a href="https://www.repostatus.org/#experimental">
<img src="https://github.com/GIScience/badges/raw/master/status/experimental.svg" alt="Project Status: Experimental – The project has reached a stable, usable state and is being actively developed."/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has not yet reached a stable state (we may need to change the API without backwards compatibility)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi pablocar80.

it has not yet reached a stable state (we may need to change the API without backwards compatibility)

change made again.

README.md Outdated
@@ -33,7 +33,7 @@
Foton is prototype for an Electron alternative written in C# by Integrative Software LLC and contributors.

## Quick start
First, download and install C# in Visual Studio - last version is required.
First, download and install C# in Visual Studio or VSCode - last version is required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this section, it doesn't really say anything

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi pablocar80.

Let's remove this section, it doesn't really say anything

change made here.

docs/README.md Outdated
<img src="https://img.shields.io/badge/License-Apache%202.0-blue.svg" alt="Foton is licensed with Apache License 2.0">
</a>
<a href="https://www.repostatus.org/#experimental">
<img src="https://github.com/GIScience/badges/raw/master/status/experimental.svg" alt="Project Status: Experimental – The project has reached a stable, usable state and is being actively developed."/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 'stable' from here too

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi pablocar80.

remove 'stable' from here too

change done here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.

Please, I hope this pull-request is good, workable. So, check all.

@pablocar80
Copy link
Member

approved, feel free to merge

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.

For some reason I can't merge.

I made a branch for a pull-request, and I expect the pull-request to pass.

Please, confirm this add 4 pull-requests: community standards, donate, deploy with ci/cd and website for docs, faq or tutorials

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pablocar80.

Only those with write access to this repository can merge pull requests.

Please, add your merge or delete or close this pull-request.

@ghost ghost deleted the branch integrativesoft:master April 5, 2023 17:06
@ghost ghost deleted the master branch April 5, 2023 17:06
@ghost ghost restored the master branch April 5, 2023 17:07
@pablocar80 pablocar80 merged commit fe06879 into integrativesoft:master May 12, 2023
@ghost
Copy link

ghost commented May 15, 2023

Hi @pablocar80, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant