Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qwen2 SDPA forward on CPU #10395

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

Uxito-Ada
Copy link
Contributor

@Uxito-Ada Uxito-Ada commented Mar 13, 2024

Description

Qwen1.5 uses Qwen2SdpaAttention rather than Qwen2Attention on CPU

1. Why the change?

#10354

2. User API changes

no

3. Summary of the change

as above

4. How to test?

  • N/A
  • Unit test
  • Application test
  • Document test
  • ...

@Uxito-Ada
Copy link
Contributor Author

Uxito-Ada commented Mar 13, 2024

Passed local test
image

@Uxito-Ada Uxito-Ada requested a review from plusbang March 13, 2024 03:17
Copy link
Contributor

@plusbang plusbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uxito-Ada Uxito-Ada merged commit 316142b into intel-analytics:main Mar 13, 2024
17 of 19 checks passed
@Uxito-Ada Uxito-Ada deleted the heyang_24_3_13 branch March 13, 2024 05:10
liu-shaojun pushed a commit that referenced this pull request Mar 25, 2024
* Fix Qwen1.5 CPU forward

* Update convert.py

* Update qwen2.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants