Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable FOV max and min #1427

Closed
pablospe opened this issue Jan 7, 2020 · 5 comments
Closed

Configurable FOV max and min #1427

pablospe opened this issue Jan 7, 2020 · 5 comments

Comments

@pablospe
Copy link
Contributor

pablospe commented Jan 7, 2020

In file ViewControl.cpp#L36:

const double ViewControl::FIELD_OF_VIEW_MAX = 90.0;

I was wondering why there is a strict max for the FOV.

As example, one could need to render a depth map from a mesh using the headless rendering example, but such strict limit would restrict the possible camera parameters that can be rendered. More precisely, I am using ConvertFromPinholeCameraParameters and this limitation happens in ViewControl.cpp#L36

field_of_view_ =
std::max(std::min(fov_rad * 180.0 / M_PI, FIELD_OF_VIEW_MAX),
FIELD_OF_VIEW_MIN);

Same for the zoom control, but there is already one issue for this purpose: issue #497

@pablospe
Copy link
Contributor Author

pablospe commented Jan 10, 2020

Related issues: #1417 and #1389
Also related issues: #727 and #834

Many people is having similar problems, I think it should be allowed a more flexible function.

@pablospe
Copy link
Contributor Author

pablospe commented Jan 10, 2020

To made it work I commented some code, something like this: pablospe@206f926

Recompile Open3D (and if you want the python wrapper):

cd build/
make install-pip-package -j16
pip3 install lib/python_package/pip_package/open3d-0.8.0.0-cp36-cp36m-linux_x86_64.whl

For headless rendering you need to activate on cmake this option: -DENABLE_HEADLESS_RENDERING=ON

pablospe added a commit to pablospe/Open3D that referenced this issue Jan 16, 2020
…meters"

Check: isl-org#1427

The reason why I don't use the mentioned branch it is beacuse it didn't
work (with error, too many files open).
@radmahdi
Copy link

radmahdi commented Apr 2, 2020

To made it work I commented some code, something like this: pablospe@206f926

I am afraid this just ignores the assert function, and the parameters are not really taken into account!

@germanros1987
Copy link
Contributor

@pablospe this is solved in the new version rendering API.

@pablospe
Copy link
Contributor Author

pablospe commented Nov 3, 2020

From what I see there is not a way to render to an image or depthmap with the current API (the equivalent to capture_depth_float_buffer). Also the option to use intrinsic/extrinsic matrix to control the view.

Based on this replies:
#2190 (comment)
#2190 (comment)

Do you have more information about it?

Also I recently pushed a PR #2564, which allows this with the old viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants