use nodehandles to enable easier remapping #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tfoote -- In the short term, this change as-is breaks the way we are handling multi-camera support, as we've been handling the camera namespace remapping ourselves. We are looking into tweaking this so our regression tests still pass backward compatibility. For getting the turtlebot integration namespacing to work, we have a separate fix in the works that uses our rgbd-compatibile launch file that does not insert the additional camera namespace level. |
|
#117 incorporates this change, and thus this pull request can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remapping is not supported for substrings. By creating intermediate nodehandles the namespaces can be remapped in aggregate. Without this my testing of turtlebot/turtlebot_apps#152 was failing due to partial remappings.