This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
Make the name generator more random #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The random shuffle algorithm used by the name generator was buggy. It swapped N pairs of randomly selected names, where N is the total number of names. What it should have been doing was swapping each name with a randomly chosen name. This makes it much more likely that each name will be moved from its original position in the slice of possible names. There should be fewer alarmed-agravains from now on. Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
rbradford
approved these changes
Apr 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The random shuffle algorithm used by the name generator was buggy.
It swapped N pairs of randomly selected names, where N is the total
number of names. What it should have been doing was swapping each
name with a randomly chosen name. This makes it much more likely
that each name will be moved from its original position in the
slice of possible names. There should be fewer alarmed-agravains
from now on.
Signed-off-by: Mark Ryan mark.d.ryan@intel.com