Skip to content
This repository has been archived by the owner on Aug 25, 2024. It is now read-only.

model: tensorflow: dnnc: DNNClassifierModelContext first init arg should be features not config #216

Closed
johnandersen777 opened this issue Oct 9, 2019 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest 2019 kind/ml Issues partaining to machine learning

Comments

@johnandersen777
Copy link

class DNNClassifierModelContext(TensorflowModelContext):
"""
Model using tensorflow to make predictions. Handels creation of feature
columns for real valued, string, and list of real valued features.
"""
def __init__(self, config, parent) -> None:
super().__init__(config, parent)

should be:

 class DNNClassifierModelContext(TensorflowModelContext): 
     """ 
     Model using tensorflow to make predictions. Handels creation of feature 
     columns for real valued, string, and list of real valued features. 
     """ 
  
     def __init__(self, features, parent) -> None: 
         super().__init__(features, parent) 
@johnandersen777 johnandersen777 added bug Something isn't working good first issue Good for newcomers kind/ml Issues partaining to machine learning hacktoberfest hacktoberfest 2019 labels Oct 9, 2019
@DimaPoliuha
Copy link
Contributor

Can I pick this issue?

@johnandersen777
Copy link
Author

@DmitryPoliuha sure! Thanks! Make sure to note the change in the CHANGELOG.md, or the CI will fail.

@DimaPoliuha
Copy link
Contributor

@pdxjohnny I've made a pull request

johnandersen777 pushed a commit to johnandersen777/dffml that referenced this issue Oct 14, 2019
* Renamed DNNClassifierModelContext first init arg from config
  to features

Fixes: intel#216
johnandersen777 pushed a commit to johnandersen777/dffml that referenced this issue Mar 11, 2022
* Renamed DNNClassifierModelContext first init arg from config
  to features

Fixes: intel#216
johnandersen777 pushed a commit that referenced this issue Mar 12, 2022
* Renamed DNNClassifierModelContext first init arg from config
  to features

Fixes: #216
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest 2019 kind/ml Issues partaining to machine learning
Projects
None yet
Development

No branches or pull requests

2 participants