Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

m4/log.m4 contains bashisms #41

Closed
desrt opened this issue Jan 25, 2014 · 3 comments
Closed

m4/log.m4 contains bashisms #41

desrt opened this issue Jan 25, 2014 · 3 comments
Labels

Comments

@desrt
Copy link

desrt commented Jan 25, 2014

On many systems, #!/bin/sh is not bash.

Meanwhile, autoconf generates its ./configure script with #!/bin/sh at the top and dleyna-core (and -dbus-connector and -renderer) use arrays (which are a bash extension) from the DLEYNA_LOG_LEVEL_CHECK macro in m4/log.m4.

It's possible to work around this issue by calling autogen.sh with the CONFIG_SHELL variable set to the location of bash, but this is suboptimal. It must surely be possible to rewrite this macro in a way such that it doesn't depend on bash.

jku added a commit to jku/dleyna-core that referenced this issue Jul 2, 2014
Fixes intel#41.

Signed-off-by: Jussi Kukkonen <jku@goto.fi>
@jku jku self-assigned this Jul 2, 2014
jku added a commit to jku/dleyna-core that referenced this issue Jul 2, 2014
Fixes intel#41.

Signed-off-by: Jussi Kukkonen <jku@goto.fi>
@jku
Copy link
Contributor

jku commented Jul 7, 2014

@rsbells or @rasikana please review (if you can, it's m4...)

The _DLEYNA_LOG_LEVEL_CHECK_VALUE macro is pure error checking for --log-level: you can only input 0,7 or 8 as single values or any combination of 1,2,3,4,5 and 6: anything else should result in error.

@jku jku added the for-next label Jul 8, 2014
jku added a commit to jku/dleyna-core that referenced this issue Jul 8, 2014
Fixes intel#41.

Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
@rsbells
Copy link
Contributor

rsbells commented Jul 10, 2014

I looked at the m4 changes and they looked fine. It looks like you already signed-off on them. Do you need me to do anything else?

@jku
Copy link
Contributor

jku commented Jul 11, 2014

No, just wanted a second pair of eyes to look at it. Thanks, I'll merge

@jku jku closed this as completed in 20c77a2 Jul 11, 2014
@bhydex bhydex unassigned jku Oct 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants