This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
m4/log.m4 contains bashisms #41
Labels
Comments
jku
added a commit
to jku/dleyna-core
that referenced
this issue
Jul 2, 2014
Fixes intel#41. Signed-off-by: Jussi Kukkonen <jku@goto.fi>
jku
added a commit
to jku/dleyna-core
that referenced
this issue
Jul 2, 2014
Fixes intel#41. Signed-off-by: Jussi Kukkonen <jku@goto.fi>
@rsbells or @rasikana please review (if you can, it's m4...) The _DLEYNA_LOG_LEVEL_CHECK_VALUE macro is pure error checking for --log-level: you can only input 0,7 or 8 as single values or any combination of 1,2,3,4,5 and 6: anything else should result in error. |
jku
added a commit
to jku/dleyna-core
that referenced
this issue
Jul 8, 2014
Fixes intel#41. Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
I looked at the m4 changes and they looked fine. It looks like you already signed-off on them. Do you need me to do anything else? |
No, just wanted a second pair of eyes to look at it. Thanks, I'll merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On many systems, #!/bin/sh is not bash.
Meanwhile, autoconf generates its ./configure script with #!/bin/sh at the top and dleyna-core (and -dbus-connector and -renderer) use arrays (which are a bash extension) from the DLEYNA_LOG_LEVEL_CHECK macro in m4/log.m4.
It's possible to work around this issue by calling autogen.sh with the CONFIG_SHELL variable set to the location of bash, but this is suboptimal. It must surely be possible to rewrite this macro in a way such that it doesn't depend on bash.
The text was updated successfully, but these errors were encountered: