[Binding] enable mlir python binding for graph compiler #91
Conversation
|
@WangJialei-A you can develop bench gc based on bindings of this PR |
| # TODO: Add an upstream cmake param for this vs having a global here. | ||
| add_compile_definitions("MLIR_PYTHON_PACKAGE_PREFIX=gc_mlir.") | ||
|
|
||
|
|
There was a problem hiding this comment.
can we add a cmake option to turn off the pybind even if LLVM has python enabled?
There was a problem hiding this comment.
can we add a cmake option to turn off the pybind even if LLVM has python enabled?
yes， I can add a new cmake option for the gc pybind, should we set the default value to OFF?
There was a problem hiding this comment.
@ZhennanQin Do we need pybind by default? Or should we only target onednn graph api for now?
There was a problem hiding this comment.
Suggest to enable pybind by default as this is the way for release. For develop purposes, you can turn it off with extra cmake flag.
There was a problem hiding this comment.
CMakeLists.txt
Outdated
| @@ -33,6 +51,16 @@ include(AddLLVM) | |||
| include(AddMLIR) | |||
| include(HandleLLVMOptions) | |||
|
|
|||
| if(GC_ENABLE_BINDINGS_PYTHON AND NOT MLIR_ENABLE_BINDINGS_PYTHON) | |||
| message(STATUS "Enabling Python API failed due to the 'MLIR_ENABLE_BINDINGS_PYTHON' for LLVM is not ON.") | |||
There was a problem hiding this comment.
Wording: Failed to enable Python API ...
There was a problem hiding this comment.
Would you please also update the readme of the for the cmake command. The main branch has updated the readme now.
There was a problem hiding this comment.
Would you please also update the readme of the for the cmake command. The main branch has updated the readme now.
have updated the readme of main project, and I will update a more specific readme in the python dir after binding more dialects in the future
|
@WangJialei-A @Menooker could you please help approve this PR if it looks good to you, thanks! |
|
Hi, @xurui1995 |
| #===------------------------------------------------------------------------===# | ||
|
|
||
| from ._onednn_graph_ops_gen import * | ||
| from .._mlir_libs._gc_mlir.onednn_graph import * |
There was a problem hiding this comment.
@xurui1995
There is no _gc_mlir folder generated in the build. Vscode failed to lint this package in my environment.
Enable basic mlir python binding for
onednngraph dialectand passes ingc/Transforms, will add support for more dialects and related passes in the next PR.Tracking #57