Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in ipmctl command invocation produces segmentation fault #150

Open
Mark-Baker opened this issue Sep 10, 2020 · 3 comments
Open

typo in ipmctl command invocation produces segmentation fault #150

Mark-Baker opened this issue Sep 10, 2020 · 3 comments

Comments

@Mark-Baker
Copy link

Mark-Baker commented Sep 10, 2020

This demonstrates with both 3797 and 3809 (I didn't test earlier versions against this issue)
ipmctl show -dimm 1 -error media
DimmID | System Timestamp | Error Type

0x0001 | 09/10/2020 17:50:31 | 0x00 - Uncorrectable
0x0001 | 09/10/2020 17:50:31 | 0x06 - Smart Health Status Change
Show Error executed successfully

ipmctl show -dimm 1 -error medai
NVM_DBG_LOGGER NVDIMM-ERR:ShowErrorCommand.c::ShowErrorCommand:719: Failed to buffer a command status object! (0x2)
Segmentation fault (core dumped)
[ 971.279449] ipmctl[10545]: segfault at 0 ip 0000000000000000 sp 00007ffff2dcb418 error 14 in ipmctl[55baeadf0000+1000]
[ 971.291368] Code: Bad RIP value.
NVM_DBG_LOGGER NVDIMM-ERR:ShowErrorCommand.c::ShowErrorCommand:719: Failed to buffer a command status object! (0x2)

#ipmctl version
Intel(R) Optane(TM) Persistent Memory Command Line Interface Version 02.00.00.3809

@StevenPontsler
Copy link
Contributor

Thanks for letting us know. We will look into it.

What was the command that was ran? It looks like a form of show -error.

What type of system was this seen on?

@sscargal
Copy link
Contributor

sscargal commented Sep 10, 2020

I confirmed the issue is reproducible on ipmctl 02.00.00.3781.

Working:

# ipmctl show -error Thermal
No errors found on PMem module 0x0001
No errors found on PMem module 0x0011
No errors found on PMem module 0x0021
No errors found on PMem module 0x0101
No errors found on PMem module 0x0111
No errors found on PMem module 0x0121
No errors found on PMem module 0x1001
No errors found on PMem module 0x1011
No errors found on PMem module 0x1021
No errors found on PMem module 0x1101
No errors found on PMem module 0x1111
No errors found on PMem module 0x1121
Show Error executed successfully

Not working (Note the the extra 's', although any spelling error causes the core dump)

# ipmctl show -error Thermals
NVM_DBG_LOGGER NVDIMM-ERR:ShowErrorCommand.c::ShowErrorCommand:719: Failed to buffer a command status object! (0x2)

Segmentation fault (core dumped)
# ipmctl show -error Medias
NVM_DBG_LOGGER NVDIMM-ERR:ShowErrorCommand.c::ShowErrorCommand:719: Failed to buffer a command status object! (0x2)

Segmentation fault (core dumped)

dmesg reports the following for each core dump

[1725987.671076] ipmctl[211195]: segfault at 0 ip 0000000000000000 sp 00007ffc902c6678 error 14 in ipmctl[56369238f000+1000]
[1725987.671676] Code: Bad RIP value.
[1726005.741750] ipmctl[211207]: segfault at 0 ip 0000000000000000 sp 00007ffc9a283908 error 14 in ipmctl[55dd3bfb7000+1000]
[1726005.742363] Code: Bad RIP value.

I didn't try all the commands and options, but other show commands return an expected error when we have a typo, eg:

# ipmctl show -pcd Configy
Syntax Error: Incorrect value for target -pcd.

ipmctl show -pcd Config works as expected.

@Mark-Baker
Copy link
Author

Mark-Baker commented Sep 11, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants