Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledctl: SGPIO EM not supported for /sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0 #134

Closed
hboetes opened this issue Apr 12, 2023 · 7 comments
Closed

ledctl: SGPIO EM not supported for /sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0 #134

hboetes opened this issue Apr 12, 2023 · 7 comments

Comments

@hboetes
Copy link

hboetes commented Apr 12, 2023

Hi there,

I just compiled ledmon(8) straight from git and I got this output:

# ledctl --all -L
ledctl: SGPIO EM not supported for /sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0
ledctl: controller discovery: /sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0 - enclosure management not supported.
ledctl: SGPIO EM not supported for /sys/devices/pci0000:80/0000:80:08.2/0000:83:00.0
ledctl: controller discovery: /sys/devices/pci0000:80/0000:80:08.2/0000:83:00.0 - enclosure management not supported.
ledctl: AMD Drive: port 7, ata port 17, drive bay 1, initiator 1
ledctl: AMD Drive: port 6, ata port 8, drive bay 2, initiator 1
/sys/devices/pci0000:40/0000:40:08.3/0000:46:00.0 (AMD)
/sys/devices/pci0000:40/0000:40:08.2/0000:45:00.0 (AMD)

Any other information you might need?
@bkucman
Copy link
Contributor

bkucman commented Apr 12, 2023

Hi @hboetes ,

please provide more information:

  • distribution and OS version,
  • more information about the controller type which is mentioned as unsupported,
  • output of "lshw -c storage -c disk",
  • content of files "/sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0/em_buffer/em_message_supported" and "/sys/devices/pci0000:80/0000:80:08.2/0000:83:00.0/em_buffer/em_message_supported".

@nfont could you check if it's just a unsupported controller or a bug?

Regards
Blazej

@hboetes
Copy link
Author

hboetes commented Apr 12, 2023

Hello @bkucman, thanks for your reply.

* distribution and OS version,

proxmox, which is a debian clone with a ubuntu kernel for the zfs support.

* more information about the controller type which is mentioned as unsupported,

Does this answer the question?

  *-sata
       description: SATA controller
       product: FCH SATA Controller [AHCI mode]
       vendor: Advanced Micro Devices, Inc. [AMD]
       physical id: 0
       bus info: pci@0000:83:00.0
       version: 51
       width: 32 bits
       clock: 33MHz
       capabilities: sata pm pciexpress msi ahci_1.0 bus_master cap_list
       configuration: driver=ahci latency=0
       resources: irq:56 memory:bc100000-bc1007ff

* output of "lshw -c storage -c disk",

# lshw -c storage -c disk
  *-sata                    
       description: SATA controller
       product: FCH SATA Controller [AHCI mode]
       vendor: Advanced Micro Devices, Inc. [AMD]
       physical id: 0
       bus info: pci@0000:45:00.0
       logical name: scsi6
       logical name: scsi7
       logical name: scsi8
       logical name: scsi9
       version: 51
       width: 32 bits
       clock: 33MHz
       capabilities: sata pm pciexpress msi ahci_1.0 bus_master cap_list emulated
       configuration: driver=ahci latency=0
       resources: irq:61 memory:b0400000-b04007ff
     *-disk:0
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 0
          bus info: scsi@6:0.0.0
          logical name: /dev/sda
          version: 204Q
          serial: S6EKNE0T201975
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sda
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=ad384e3f-12f6-46a1-af42-24f5bfcc963f
     *-disk:1
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 1
          bus info: scsi@7:0.0.0
          logical name: /dev/sdb
          version: 204Q
          serial: S6EKNE0T201965
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdb
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=f6a0e77f-7c5d-4031-a834-37325d514e4f
     *-disk:2
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 2
          bus info: scsi@8:0.0.0
          logical name: /dev/sdc
          version: 204Q
          serial: S6EKNE0T201972
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdc
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=de3baa21-8f0c-4b44-868a-090c9b16d59c
     *-disk:3
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 3
          bus info: scsi@9:0.0.0
          logical name: /dev/sdd
          version: 204Q
          serial: S6EKNE0T201962
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdd
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=bc258eb9-4479-4b89-a83d-e4d9b5b4578b
  *-sata
       description: SATA controller
       product: FCH SATA Controller [AHCI mode]
       vendor: Advanced Micro Devices, Inc. [AMD]
       physical id: 0
       bus info: pci@0000:46:00.0
       logical name: scsi16
       logical name: scsi17
       logical name: scsi10
       logical name: scsi11
       logical name: scsi12
       logical name: scsi13
       logical name: scsi14
       logical name: scsi15
       version: 51
       width: 32 bits
       clock: 33MHz
       capabilities: sata pm pciexpress msi ahci_1.0 bus_master cap_list emulated
       configuration: driver=ahci latency=0
       resources: irq:78 memory:b0300000-b03007ff
     *-disk:0
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 0
          bus info: scsi@16:0.0.0
          logical name: /dev/sdk
          version: 204Q
          serial: S6EKNE0T201964
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdk
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=5ea309d3-0d65-4e0b-9f19-ee99696a85e3
     *-disk:1
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 1
          bus info: scsi@17:0.0.0
          logical name: /dev/sdl
          version: 204Q
          serial: S6EKNE0T201954
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdl
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=b5496239-40e5-4687-9bdb-c85a2181d996
     *-disk:2
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 2
          bus info: scsi@10:0.0.0
          logical name: /dev/sde
          version: 204Q
          serial: S6EKNE0T202382
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sde
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=498e8e15-96b9-4b1d-a59e-1d891c5b9dd1
     *-disk:3
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 3
          bus info: scsi@11:0.0.0
          logical name: /dev/sdf
          version: 204Q
          serial: S6EKNE0T201959
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdf
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=4cbca1e9-a8ef-41f9-9e60-ff994a5c3a73
     *-disk:4
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 4
          bus info: scsi@12:0.0.0
          logical name: /dev/sdg
          version: 204Q
          serial: S6EKNE0T201968
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdg
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=ce7c55d0-054a-4b66-826f-d038921dd581
     *-disk:5
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 5
          bus info: scsi@13:0.0.0
          logical name: /dev/sdh
          version: 204Q
          serial: S6EKNE0T201967
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdh
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=faf61d49-3d32-48b8-91b5-1f668f101925
     *-disk:6
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 6
          bus info: scsi@14:0.0.0
          logical name: /dev/sdi
          version: 204Q
          serial: S6EKNE0T201957
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdi
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=fb5b0958-0f10-4b16-a6bb-1be172bc109d
     *-disk:7
          description: ATA Disk
          product: SAMSUNG MZ7L3960
          physical id: 7
          bus info: scsi@15:0.0.0
          logical name: /dev/sdj
          version: 204Q
          serial: S6EKNE0T202388
          size: 894GiB (960GB)
          capabilities: removable
          configuration: ansiversion=5 logicalsectorsize=512 sectorsize=4096
        *-medium
             physical id: 0
             logical name: /dev/sdj
             size: 894GiB (960GB)
             capabilities: gpt-1.00 partitioned partitioned:gpt
             configuration: guid=c0147971-766d-4501-b7e8-fa4d9e1e8b82
  *-sata
       description: SATA controller
       product: FCH SATA Controller [AHCI mode]
       vendor: Advanced Micro Devices, Inc. [AMD]
       physical id: 0
       bus info: pci@0000:83:00.0
       version: 51
       width: 32 bits
       clock: 33MHz
       capabilities: sata pm pciexpress msi ahci_1.0 bus_master cap_list
       configuration: driver=ahci latency=0
       resources: irq:56 memory:bc100000-bc1007ff
  *-sata
       description: SATA controller
       product: FCH SATA Controller [AHCI mode]
       vendor: Advanced Micro Devices, Inc. [AMD]
       physical id: 0
       bus info: pci@0000:84:00.0
       version: 51
       width: 32 bits
       clock: 33MHz
       capabilities: sata pm pciexpress msi ahci_1.0 bus_master cap_list
       configuration: driver=ahci latency=0
       resources: irq:59 memory:bc000000-bc0007ff

* content of files "/sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0/em_buffer/em_message_supported" and "/sys/devices/pci0000:80/0000:80:08.2/0000:83:00.0/em_buffer/em_message_supported".

The em_buffer directories do not exist on this host. Is there a module I'm missing? How do I get them?

@bkucman
Copy link
Contributor

bkucman commented Apr 13, 2023 •
edited
Loading

Hi @hboetes,

The em_buffer directories do not exist on this host. Is there a module I'm missing? How do I get them?

Sorry I misinterpreted the location of this file "em_message_supported".
I don't have AMD hardware but based on Intel SATA controller file should be in a path similar to below

Example from my hardware:
/sys/devices/pci0000:00/0000:00:17.0/ata19/host18/scsi_host/host18/em_message_supported

According to you controller, start searching from this path
/sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0/

You can also enter to above path and search for that file :)
e.g. find ./ -name "em_message_supported"

if it's not there, for more info you will have to wait for @nfont who has AMD expertise.

Regards
Blazej

@nfont
Copy link
Contributor

nfont commented Apr 13, 2023

Hi @hboetes ,

Looking at the output you posted from the ledctl command, the message "SGPIO EM not supported for /sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0" indicates that the platform does not support SGPIO enclosure management. This can also be sen in your output from lshw for the sata device. The capabilities listed does not include 'sgpio'.

The ledctl code does provide reference implementations for using IPMI to control LEDs. If you're comfortable trying an update you could add a check for your platform to amd_em_enabled() to see if that works for your platform. The code defaults to SGPIO and then checks to see if this is a platform that uses IPMI. See the check for IPMI for the ETHANOL_X and DAYTONA_X platforms in the amd_em_enabled() routine.

@hboetes
Copy link
Author

hboetes commented Apr 13, 2023

@bkucman

Thanks for your reply,

The output is rather disappointing:

# cat /sys/devices/pci0000:80/0000:80:08.3/0000:84:00.0/ata2/host1/scsi_host/host1/em_message_supported

@hboetes
Copy link
Author

hboetes commented Apr 13, 2023

@nfont
Thanks for your reply. This will take some researching to get working.

@bkucman
Copy link
Contributor

bkucman commented Aug 9, 2023

As it is not a defect, just no support for the described hardware, I close the issue.
If you encounter problems with the implementation of support, feel free to open a new issue with an appropriate description.

Thanks,
Blazej

@bkucman bkucman closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hboetes @nfont @bkucman