Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateBuffer/VAAPICreateBuffer.CreateBufferWithOutData/326 failed #89

Closed
XinfengZhang opened this issue Jan 10, 2018 · 3 comments
Closed
Assignees

Comments

@XinfengZhang
Copy link
Contributor

call vaCreateBuffer with such parameters (size = 4, num_elements=1, VAEncSequenceParameterBufferType), it return invalidate parameter , because size < sizeof(VAEncSequenceParameterBufferType)

@uartie
Copy link
Contributor

uartie commented Jan 11, 2018

Yes, size should actually be the size of the actual buffer structure (i.e. sizeof(VAEncSequenceParameterBufferH264) in this case) not the size of the buffer "type". So this is a bug in the tests. I will fix this.

@XinfengZhang
Copy link
Contributor Author

a series of test case is related with the issue. ASSERT_STATUS(vaCreateBuffer(m_vaDisplay, m_contextID, bufferType,
sizeof(bufferType), 1, NULL, &m_bufferID)); maybe we need set a map from bufferType to buffer structure

@uartie
Copy link
Contributor

uartie commented Jan 11, 2018

@XinfengZhang agree. I am working on patches now...

@uartie uartie self-assigned this Jan 16, 2018
uartie added a commit to uartie/libva-utils that referenced this issue Jan 22, 2018
vaCreateBuffer needs the sizeof the actual buffer
data structure associated with the buffer type, which
could be profile specific.

Previous test logic was passing the sizeof the
buffer "type" enum, which is wrong.

Fix the tests so that the correct buffer size is
calculated based on profile specific buffer types.

Several buffer types were removed from the previous test
parameters since their size may be application specific,
arbitrary, and/or require additional setup beyond the
capabilities of the current buffer test cases.  These
rules will need to be fleshed-out and tests for them
added later on.

Fixes intel#89

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 23, 2018
vaCreateBuffer needs the sizeof the actual buffer
data structure associated with the buffer type, which
could be profile specific.

Previous test logic was passing the sizeof the
buffer "type" enum, which is wrong.

Fix the tests so that the correct buffer size is
calculated based on profile specific buffer types.

Several buffer types were removed from the previous test
parameters since their size may be application specific,
arbitrary, and/or require additional setup beyond the
capabilities of the current buffer test cases.  These
rules will need to be fleshed-out and tests for them
added later on.

Fixes intel#89

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 23, 2018
vaCreateBuffer needs the sizeof the actual buffer
data structure associated with the buffer type, which
could be profile specific.

Previous test logic was passing the sizeof the
buffer "type" enum, which is wrong.

Fix the tests so that the correct buffer size is
calculated based on profile specific buffer types.

Several buffer types were removed from the previous test
parameters since their size may be application specific,
arbitrary, and/or require additional setup beyond the
capabilities of the current buffer test cases.  These
rules will need to be fleshed-out and tests for them
added later on.

Fixes intel#89

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 29, 2018
vaCreateBuffer needs the sizeof the actual buffer
data structure associated with the buffer type, which
could be profile specific.

Previous test logic was passing the sizeof the
buffer "type" enum, which is wrong.

Fix the tests so that the correct buffer size is
calculated based on profile specific buffer types.

Several buffer types were removed from the previous test
parameters since their size may be application specific,
arbitrary, and/or require additional setup beyond the
capabilities of the current buffer test cases.  These
rules will need to be fleshed-out and tests for them
added later on.

Fixes intel#89

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 29, 2018
vaCreateBuffer needs the sizeof the actual buffer
data structure associated with the buffer type, which
could be profile specific.

Previous test logic was passing the sizeof the
buffer "type" enum, which is wrong.

Fix the tests so that the correct buffer size is
calculated based on profile specific buffer types.

Several buffer types were removed from the previous test
parameters since their size may be application specific,
arbitrary, and/or require additional setup beyond the
capabilities of the current buffer test cases.  These
rules will need to be fleshed-out and tests for them
added later on.

Fixes intel#89

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit that referenced this issue Jan 30, 2018
vaCreateBuffer needs the sizeof the actual buffer
data structure associated with the buffer type, which
could be profile specific.

Previous test logic was passing the sizeof the
buffer "type" enum, which is wrong.

Fix the tests so that the correct buffer size is
calculated based on profile specific buffer types.

Several buffer types were removed from the previous test
parameters since their size may be application specific,
arbitrary, and/or require additional setup beyond the
capabilities of the current buffer test cases.  These
rules will need to be fleshed-out and tests for them
added later on.

Fixes #89

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants