FeatureRequest: doLogSkipTest should be made descriptive #99
Comments
|
In addition, I think doLogSkipTest should only set a flag (e.g. m_skipped), along with your suggested generic message, and the current logic be moved to the destructor where skipped message is only generated when |
uartie
added a commit
to uartie/libva-utils
that referenced
this issue
Jan 23, 2018
Allow custom skip test message. Basic checks to determine whether a test should be skipped could fail (e.g. query profiles/entrypoints to determine if test should be skipped). Thus, don't log test as skipped if there are any failures before the test fixture destructs. Fixes intel#99 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie
added a commit
to uartie/libva-utils
that referenced
this issue
Jan 23, 2018
Allow custom skip test message. Basic checks to determine whether a test should be skipped could fail (e.g. query profiles/entrypoints to determine if test should be skipped). Thus, don't log test as skipped if there are any failures before the test fixture destructs. Fixes intel#99 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie
added a commit
to uartie/libva-utils
that referenced
this issue
Jan 23, 2018
Allow custom skip test message. Basic checks to determine whether a test should be skipped could fail (e.g. query profiles/entrypoints to determine if test should be skipped). Thus, don't log test as skipped if there are any failures before the test fixture destructs. Fixes intel#99 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie
added a commit
to uartie/libva-utils
that referenced
this issue
Jan 29, 2018
Allow custom skip test message. Basic checks to determine whether a test should be skipped could fail (e.g. query profiles/entrypoints to determine if test should be skipped). Thus, don't log test as skipped if there are any failures before the test fixture destructs. Fixes intel#99 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Merged
uartie
added a commit
to uartie/libva-utils
that referenced
this issue
Jan 29, 2018
Allow custom skip test message. Basic checks to determine whether a test should be skipped could fail (e.g. query profiles/entrypoints to determine if test should be skipped). Thus, don't log test as skipped if there are any failures before the test fixture destructs. Fixes intel#99 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie
added a commit
that referenced
this issue
Jan 30, 2018
Allow custom skip test message. Basic checks to determine whether a test should be skipped could fail (e.g. query profiles/entrypoints to determine if test should be skipped). Thus, don't log test as skipped if there are any failures before the test fixture destructs. Fixes #99 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
doLogSkipTest in fixture class should be able to differentiate between skip reason (ie. due to non supported profile or non supported entrypoint). And/OR should be able to accept generic arguments for skip reason.
The text was updated successfully, but these errors were encountered: