Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure should FAIL when --enable-wayland requirements can't be met #68

Closed
uartie opened this issue Jun 15, 2017 · 1 comment
Closed
Labels

Comments

@uartie
Copy link
Contributor

uartie commented Jun 15, 2017

Currently, configure silently disables wayland support if requirements cannot be met, even when the user explicitly requests it via --enable-wayland. If the user does not explicitly request it, then silently disabling it is ok. However, when the user explicitly provides --enable-wayland to configure, configure should fail if wayland requirements/dependencies can't be met.

@uartie uartie added the bug label Jun 15, 2017
@uartie
Copy link
Contributor Author

uartie commented Jun 16, 2017

Same rules should apply for --enable-drm --enable-x11 --enable-glx --enable-egl

xhaihao referenced this issue in xhaihao/libva Jun 20, 2017
Notify user an error if user provides --enable-x11/--enable-glx/--enable-egl/--enable-wayland
however the requirement can't be met. drm has been checked mandatorily
in the script

v2: Remove XEXT_CFLAGS/XFIXES_CFLAGS from va/x11/Makefile.am and use
$X11_PKG_ERRORS in the error message if the requirement is met for VA/X11

This fixes https://github.com/01org/libva/issues/68

Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Reviewed-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
xhaihao referenced this issue Aug 16, 2017
Notify user an error if user provides --enable-x11/--enable-glx/--enable-egl/--enable-wayland
however the requirement can't be met. drm has been checked mandatorily
in the script

v2: Remove XEXT_CFLAGS/XFIXES_CFLAGS from va/x11/Makefile.am and use
$X11_PKG_ERRORS in the error message if the requirement is met for VA/X11

This fixes https://github.com/01org/libva/issues/68

Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
Reviewed-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
(cherry picked from commit b9a72b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant