This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
compile for chromeos and suppress some warning #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. enable pre-commit hooks by
cp pre-commit .git/hooks/
2. pre-commit will call kr_styly.sh for changed source file
kr_style changes isn't commited by default,
a) you can check it by 'git diff'
b) you can accept the changes by 'git commit -a --amend'
or reject it by 'git reset --hard'
3. pre-commit also remove executable bit('x') for changed source file
4. pre-commit will remove trailing-whitespace
5. add '--indent-modifiers' with kr style to avoid some known issues
| vaBuffers[0] = paramBuf->getID(); | ||
| vaBuffers[1] = dataBuf->getID(); | ||
| if (!renderVaBuffer | ||
| (paramBuf, "vaRenderPicture(), render slice param")) |
There was a problem hiding this comment.
need clear rendered objects in m_sliceArray before return false.
else it may crash the program in cleanup.
added 5 commits
April 17, 2014 10:18
suppress the compile warning for 'delete m_display'
it sliently work around psb driver issue. psb driver always destroy vaBuffer after it is rendered, it creates issue if yami destroy vaBuffer at a later time. for example(with psb driver): picture/vaSurface M has vaBuffer N; vaBuffer N is release after decoding picture M. then when we create M+1 picture/vaSurface, its associated vaBuffer id is also N, (not N+1). if we delete M picture/vaSurface, N vaBuffer is deleted as well. this makes vaBuffer(N) of M+1 picture/vaSurface invalid.
1. on chromeos, the buffer info in ::start() isn't the real geometry
of the video, so we defer the initialization to the first key frame
2. we also reset the decoder when frame_size becomes larger to support
dynamic resolution of vp8
3. delete picture after using, though psb video driver automatically
delete the rendered vaBuffer.
the work around for psb video driver is done by previous commit
|
OK to me |
|
+1 |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure why it pass compile on Linux,
add "#include <stdint.h>" to pass compile on chromeos.