This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
fix reset context bug && fix profile support bug #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
-1
|
| @@ -64,6 +64,11 @@ static VAProfile getH264VAProfile(H264PPS * pps) | |||
| (pps->num_slice_groups_minus1 == 0 && | |||
| !pps->redundant_pic_cnt_present_flag)) | |||
| profile = VAProfileH264ConstrainedBaseline; | |||
| else { | |||
| ERROR("h264 baseline profile is not supported"); | |||
| profile = VAProfileNone; | |||
There was a problem hiding this comment.
Our decoder may running on different target. Do not assume it's no baseline profile supported.We need query this from VA.
|
yes. profile should not be assumed here. i think that there are two way to refine:
|
| if (parsedProfile != m_configBuffer.profile) { | ||
| DEBUG("H264: profile changed: old = %d, new = %d, \n", | ||
| m_configBuffer.profile, parsedProfile); | ||
| m_configBuffer.profile = parsedProfile; | ||
| m_configBuffer.flag |= HAS_VA_PROFILE; |
There was a problem hiding this comment.
here are exist code. why we not set the flag before your commit .
added 2 commits
April 22, 2014 15:09
Signed-off-by: Zhong Cong <congx.zhong@intel.com>
Signed-off-by: Zhong Cong <congx.zhong@intel.com>
|
+1 |
|
+1 |
|
thanks. Now i can push my patch to 01org. |
This was referenced Sep 8, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.