Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem described in issue #40 #43

Merged
merged 4 commits into from
Nov 10, 2016
Merged

Fixes problem described in issue #40 #43

merged 4 commits into from
Nov 10, 2016

Conversation

rodolfoams
Copy link
Contributor

Updates get_arch() function in scripts in order to support all system languages.

…h script to support all system languages.

The old get_arch() function would only work on systems configured in English, since it looked for the 'Class:' string.
The new get_arch() function uses the 'magic' information from the readelf output to determine the architecture of the build from generated binary.

Signed-off-by: Rodolfo Silva <rodolfo@grupomarinho.com.br>
…ll.sh script to support all system languages.

The old get_arch() function would only work on systems configured in English, since it looked for the 'Class:' string.
The new get_arch() function uses the 'magic' information from the readelf output to determine the architecture of the build from generated binary.

Signed-off-by: Rodolfo Silva <rodolfo@grupomarinho.com.br>
…ll.sh script to support all system languages.

The old get_arch() function would only work on systems configured in English, since it looked for the 'Class:' string.
The new get_arch() function uses the 'magic' information from the readelf output to determine the architecture of the build from generated binary.

Signed-off-by: Rodolfo Silva <rodolfo@grupomarinho.com.br>
Copy link
Contributor

@yuyuany yuyuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:
test $a = 02 && echo 'x64' || echo 'x86'

Copy link
Contributor

@yuyuany yuyuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:
test $a = 02 && echo 'x64' || echo 'x86'

Signed-off-by: Rodolfo Silva <rodolfo@grupomarinho.com.br>
@rodolfoams
Copy link
Contributor Author

Changes made on commit a49f62a6cdb969cfd4539d2fbed6de1cf8492bdb.

@yuyuany yuyuany merged commit cdf5637 into intel:master Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants