This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Tests for vec/marray math #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackAKirk
changed the title
|
This PR includes a small patch adding marray coverage to the following not yet merged PR #895 |
|
/verify with intel/llvm#6038 |
sycl::math, native and half_precision cases covered. Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
JackAKirk
force-pushed
the
math_marray_tests
branch
from
b77b376
to
f95793b
Compare
Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6038 |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6038 |
steffenlarsen
previously approved these changes
Jun 16, 2022
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6038 |
|
/verify with intel/llvm#6038 |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
…-test-suite into math_marray_tests
|
/verify with intel/llvm#6038 |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6038 |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6038 |
4 similar comments
|
/verify with intel/llvm#6038 |
|
/verify with intel/llvm#6038 |
|
/verify with intel/llvm#6038 |
|
/verify with intel/llvm#6038 |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6038 |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6038 |
1 similar comment
|
/verify with intel/llvm#6038 |
steffenlarsen
approved these changes
Oct 21, 2022
|
/verify with intel/llvm#6038 |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
bader
pushed a commit
to intel/llvm
that referenced
this pull request
Dec 2, 2022
This PR aims to fix issue: #5991 and provide efficient working marray math function implementations for all backends. marray math function support is currently switched on for {n} ({n} defined in #5991) but the implementations are currently broken and untested. There is also very limited test coverage for sycl::vec cases. The SYCL 2020 specification states that the set {N} ({N} defined in #5991) should be supported for marray math function cases. All SYCL 2020 math, native math, and half_precision math functions now have marray support when the function's arguments are of type `genfloat` and have the same argument type for all arguments. Tests: intel/llvm-test-suite#1002 Signed-off-by: jack.kirk <jack.kirk@codeplay.com> Co-authored-by: JackAKirk <chezjakirk@gmail.com> Co-authored-by: Jakub Chlanda <jakub@codeplay.com>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Tests for marray/vec SYCL math functions from: intel/llvm#6038 Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Tests for marray/vec SYCL math functions from: intel#6038 Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for marray/vec SYCL math functions from: intel/llvm#6038
Signed-off-by: jack.kirk jack.kirk@codeplay.com