[SYCL][Graph] Enable Graphs with L0 immediate command-list #12279

mfrancepillois · 2024-01-03T12:00:26Z

Updates e2e tests to test L0 immediate command-lists.
Improves filecheck usage in graph E2E tests
Removes test that checks immediate command-list exception.
Updates the spec.

Addresses Issue: #10467

Updates e2e tests to test L0 immediate command-lists. Improves filecheck usage in graph E2E tests Removes test that checks immediate command-list exception Updates the spec. Addresses Issue: intel#10467

EwanC · 2024-01-09T12:17:01Z

Noting that if either of these two PRs merge before this:

Then this PR will need updated so that the new E2E tests introduced use the same method of setting immediate command lists

reble · 2024-01-17T17:28:42Z

sycl/plugins/unified_runtime/CMakeLists.txt

+  set(UNIFIED_RUNTIME_REPO "https://github.com/bensuo/unified-runtime.git")
+  set(UNIFIED_RUNTIME_TAG maxime/imm-cmd-list-support)


Need to update target UR!

Yes, this will be updated as soon as the UR PR is merged to the main branch.

aarongreig · 2024-02-06T14:50:21Z

oneapi-src/unified-runtime#1218 has merged, please update the tag @mfrancepillois

mfrancepillois · 2024-02-07T11:02:35Z

@intel/llvm-gatekeepers could you please merge this PR?

sarnex · 2024-02-07T14:41:46Z

@mfrancepillois Seems we have a lot of post-commit fails in Graph tests on Arc. Can you take a look? If they cannot be fixed quickly I recommend reverting this PR

Failed Tests (16):
  SYCL :: Graph/Explicit/basic_usm.cpp
  SYCL :: Graph/Explicit/basic_usm_host.cpp
  SYCL :: Graph/Explicit/basic_usm_mixed.cpp
  SYCL :: Graph/Explicit/basic_usm_shared.cpp
  SYCL :: Graph/Explicit/queue_constructor_usm.cpp
  SYCL :: Graph/Explicit/sub_graph.cpp
  SYCL :: Graph/RecordReplay/after_use.cpp
  SYCL :: Graph/RecordReplay/barrier_with_work.cpp
  SYCL :: Graph/RecordReplay/basic_usm.cpp
  SYCL :: Graph/RecordReplay/basic_usm_host.cpp
  SYCL :: Graph/RecordReplay/basic_usm_mixed.cpp
  SYCL :: Graph/RecordReplay/basic_usm_shared.cpp
  SYCL :: Graph/RecordReplay/host_task_in_order.cpp
  SYCL :: Graph/RecordReplay/queue_constructor_usm.cpp
  SYCL :: Graph/RecordReplay/sub_graph.cpp
  SYCL :: Graph/RecordReplay/usm_copy.cpp

sommerlukas · 2024-02-07T14:43:40Z

@mfrancepillois Seems we have a lot of post-commit fails in Graph tests on Arc. Can you take a look? If they cannot be fixed quickly I recommend reverting this PR
Failed Tests (16):
 ...

Hi @sarnex, I'm already in touch with @mfrancepillois, we will follow up with a PR marking those tests unsupported on specific hardware, while the reason for the failure is investigated.

sarnex · 2024-02-07T14:45:32Z

@sommerlukas Great thank you!!!

sommerlukas · 2024-02-07T15:09:59Z

The PR to disable the tests temporarily is here: #12648

After PR #12279, the USM tests fail in post-commit CIs (https://github.com/intel/llvm/actions/runs/7814201804/job/21315560479). We temporarily disable these tests during the bug investigation.

mfrancepillois · 2024-02-09T10:31:14Z

The PR #12677 (linked to the UR PR oneapi-src/unified-runtime#1328 ) fixes the bug.

[SYCL][Graph] Enable Graphs with L0 immediate command-list

2a7cf1b

Updates e2e tests to test L0 immediate command-lists. Improves filecheck usage in graph E2E tests Removes test that checks immediate command-list exception Updates the spec. Addresses Issue: intel#10467

mfrancepillois mentioned this pull request Jan 3, 2024

[SYCL][Graph] Enable Graphs with L0 immediate command-list reble/llvm#347

Closed

mfrancepillois temporarily deployed to WindowsCILock January 3, 2024 12:01 — with GitHub Actions Inactive

mfrancepillois mentioned this pull request Jan 3, 2024

[EXP][CMDBUF] L0 Immediate command-list support oneapi-src/unified-runtime#1218

Merged

mfrancepillois had a problem deploying to WindowsCILock January 3, 2024 12:24 — with GitHub Actions Failure

fixes merge bug

a3a53ac

mfrancepillois temporarily deployed to WindowsCILock January 3, 2024 13:15 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock January 3, 2024 13:38 — with GitHub Actions Failure

mfrancepillois temporarily deployed to WindowsCILock January 4, 2024 17:26 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock January 4, 2024 17:26 — with GitHub Actions Failure

mfrancepillois temporarily deployed to WindowsCILock January 5, 2024 10:39 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock January 5, 2024 11:01 — with GitHub Actions Failure

Merge branch 'sycl' into maxime/imm-command-list

5698a52

mfrancepillois temporarily deployed to WindowsCILock January 5, 2024 13:34 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock January 5, 2024 13:56 — with GitHub Actions Failure

Adds USM copy test with imm cmd-list + updates run command of all tests

9f35877

mfrancepillois temporarily deployed to WindowsCILock January 5, 2024 17:10 — with GitHub Actions Inactive

aelovikov-intel mentioned this pull request Jan 5, 2024

[SYCL][Graph] Add support for fill and memset nodes in graphs #11472

Merged

mfrancepillois had a problem deploying to WindowsCILock January 5, 2024 17:42 — with GitHub Actions Failure

Bensuo mentioned this pull request Jan 10, 2024

[Windows][CI][L0] Drivers do not support zeCommandListHostSynchronize #12344

Closed

Bensuo added 2 commits January 10, 2024 14:27

Disable tests on windows due to driver issues

c90f4cb

Merge remote-tracking branch 'origin/sycl' into maxime/imm-command-list

79c3f72

Bensuo temporarily deployed to WindowsCILock January 10, 2024 14:29 — with GitHub Actions Inactive

Bensuo had a problem deploying to WindowsCILock January 10, 2024 14:52 — with GitHub Actions Failure

Disable further test on windows

a7ca3c5

Bensuo temporarily deployed to WindowsCILock January 10, 2024 16:40 — with GitHub Actions Inactive

Bensuo temporarily deployed to WindowsCILock January 10, 2024 17:01 — with GitHub Actions Inactive

mfrancepillois added 2 commits January 12, 2024 15:27

Merge branch 'sycl' into maxime/imm-command-list

9071091

Adds tests buffer fill and usm fill with imm-cmd-list

d414e38

EwanC requested a review from a team as a code owner January 17, 2024 10:49

EwanC requested a review from bso-intel January 17, 2024 10:49

reble reviewed Jan 17, 2024

View reviewed changes

bso-intel approved these changes Jan 18, 2024

View reviewed changes

EwanC approved these changes Jan 31, 2024

View reviewed changes

mfrancepillois added 2 commits February 6, 2024 16:14

Merge branch 'sycl' into maxime/imm-command-list

e67cc01

Bump UR tag to 1cd402e

5b5840c

aarongreig approved these changes Feb 6, 2024

View reviewed changes

mfrancepillois temporarily deployed to WindowsCILock February 6, 2024 16:35 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock February 6, 2024 17:12 — with GitHub Actions Failure

Disable Windows for all imm-cmd-list tests

af3f033

mfrancepillois temporarily deployed to WindowsCILock February 6, 2024 21:59 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock February 6, 2024 22:23 — with GitHub Actions Failure

Disable windows tests for imm-cmd-list (missing tests)

eca500e

mfrancepillois temporarily deployed to WindowsCILock February 7, 2024 08:34 — with GitHub Actions Inactive

mfrancepillois temporarily deployed to WindowsCILock February 7, 2024 08:55 — with GitHub Actions Inactive

sommerlukas merged commit eead989 into intel:sycl Feb 7, 2024
12 checks passed

mfrancepillois mentioned this pull request Feb 7, 2024

[SYCL][Graph] Disable USM tests on gpu-intel-dg2 #12648

Merged

EwanC mentioned this pull request Apr 5, 2024

[SYCL][Graph] Graph hangs on PVC or with explicitly used Immediate Command List #10467

Closed

This was referenced May 9, 2024

SYCL: Add support for Graphs kokkos/kokkos#6912

Open

SYCL: Add Kokkos_ENABLE_SYCL_NO_IMMEDIATE_COMMAND_LISTS option kokkos/kokkos#7003

Closed

SYCL: Print submission command queue property kokkos/kokkos#7004

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL][Graph] Enable Graphs with L0 immediate command-list #12279

[SYCL][Graph] Enable Graphs with L0 immediate command-list #12279

mfrancepillois commented Jan 3, 2024

EwanC commented Jan 9, 2024 •

edited

reble Jan 17, 2024

mfrancepillois Jan 18, 2024

aarongreig commented Feb 6, 2024

mfrancepillois commented Feb 7, 2024

sarnex commented Feb 7, 2024 •

edited

sommerlukas commented Feb 7, 2024 •

edited

sarnex commented Feb 7, 2024

sommerlukas commented Feb 7, 2024

mfrancepillois commented Feb 9, 2024

		set(UNIFIED_RUNTIME_REPO "https://github.com/bensuo/unified-runtime.git")
		set(UNIFIED_RUNTIME_TAG maxime/imm-cmd-list-support)

[SYCL][Graph] Enable Graphs with L0 immediate command-list #12279

[SYCL][Graph] Enable Graphs with L0 immediate command-list #12279

Conversation

mfrancepillois commented Jan 3, 2024

EwanC commented Jan 9, 2024 • edited

reble Jan 17, 2024

Choose a reason for hiding this comment

mfrancepillois Jan 18, 2024

Choose a reason for hiding this comment

aarongreig commented Feb 6, 2024

mfrancepillois commented Feb 7, 2024

sarnex commented Feb 7, 2024 • edited

sommerlukas commented Feb 7, 2024 • edited

sarnex commented Feb 7, 2024

sommerlukas commented Feb 7, 2024

mfrancepillois commented Feb 9, 2024

EwanC commented Jan 9, 2024 •

edited

sarnex commented Feb 7, 2024 •

edited

sommerlukas commented Feb 7, 2024 •

edited