-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Use PI APIs for cooperative kernels #12367
Conversation
This change updates the SYCL runtime to use `piextKernelSuggestMaxCooperativeGroupCount` and `piextEnqueueCooperativeKernelLaunch` for cooperative kernels. These functions are used to implement the query and launch kernels as described in the sycl_ext_oneapi_root_group extension. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: we don't run unittests in our CI, known deficiency.
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Looks like after pulling in the latest sycl branch changes and updating the UR tag there's a regression, not sure if this is realted or not.
|
Okay, seems to have gone away today after pulling in sycl branch again. @againull what are your thoughts on the readiness of this PR? |
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Co-authored-by: Artur Gainullin <artur.gainullin@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
These tests are also failing in #12783 and are unrelated to this PR. @intel/llvm-gatekeepers, I think this is ready to merge. |
Windows Gen12:
|
This change updates the SYCL runtime to use
piextKernelSuggestMaxCooperativeGroupCount
andpiextEnqueueCooperativeKernelLaunch
for cooperative kernels. These functions are used to implement the query and launch kernels as described in the sycl_ext_oneapi_root_group extension.