Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][ESIMD] Use LLVM IR for USM/SLM scatter #12628

Merged
merged 11 commits into from
Feb 8, 2024
Merged

[SYCL][ESIMD] Use LLVM IR for USM/SLM scatter #12628

merged 11 commits into from
Feb 8, 2024

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Feb 6, 2024

No description provided.

@fineg74 fineg74 marked this pull request as ready for review February 6, 2024 20:43
@fineg74 fineg74 requested a review from a team as a code owner February 6, 2024 20:43
sarnex
sarnex reviewed Feb 6, 2024
View reviewed changes
sycl/include/sycl/ext/intel/esimd/detail/memory_intrin.hpp Outdated
__esimd_svm_gather4_scaled(__ESIMD_DNS::vector_type_t<uint64_t, N> addrs,
__ESIMD_DNS::simd_mask_storage_t<N> pred = 1)
__ESIMD_INTRIN_END;
__ESIMD_DNS::vector_type_t<Ty, N * get_num_channels_enabled(Mask)>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just a whitespace change? if so can we revert it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done but whoever touches this file will get this again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry if this is done by clang-format we should keep it, I thought it was a manual typo

sycl/test/esimd/memory_properties.cpp Show resolved Hide resolved
sycl/test-e2e/ESIMD/unified_memory_api/scatter_usm_legacy.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@fineg74 fineg74 changed the title [SYCL][ESIMD] Use LLVM IR for USM scatter [SYCL][ESIMD] Use LLVM IR for USM/SLM scatter Feb 7, 2024
v-klochkov
v-klochkov reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. I have only few minor comments.

llvm/lib/SYCLLowerIR/ESIMD/LowerESIMD.cpp Outdated Show resolved Hide resolved
sycl/test-e2e/ESIMD/unified_memory_api/scatter_usm_legacy.cpp Outdated Show resolved Hide resolved
sycl/test-e2e/ESIMD/unified_memory_api/slm_scatter_legacy.cpp Outdated Show resolved Hide resolved
sycl/test/esimd/memory_properties.cpp Show resolved Hide resolved
@v-klochkov v-klochkov merged commit 7ee7e90 into intel:sycl Feb 8, 2024
12 checks passed
@fineg74 fineg74 deleted the IRScatter branch February 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fineg74 @sarnex @v-klochkov