-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Bindless] Add mipmap interop + slight redesign + bug fix #12736
[SYCL][Bindless] Add mipmap interop + slight redesign + bug fix #12736
Conversation
Mipmap interop: - Remove "interop" image type as it is redundant for image creation - Add a vulkan mipmap interop test Slight redesign: - Simplify external resources Modify the bindless spec to reflect these changes Fix Vulkan interop tests to prevent memory leak issue by freeing mapped memory
e43e356
to
761d8c1
Compare
Friendly ping to @intel/unified-runtime-reviewers, @intel/llvm-reviewers-runtime, and @sergey-semenov reviews/approvals/merging. The CI failures appear to be unrelated to these changes. |
sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runtime owned files LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oneapi-src/unified-runtime#1351 has been merged, please pull in the latest sycl branch changes, resolve the conflict, update the UR repo/tag as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UR LGTM
@intel/llvm-gatekeepers can we merge this please? |
…released (#12992) UR Part: oneapi-src/unified-runtime#1431 Depends on #12736 merging first.
Mipmap interop:
Slight redesign:
Modify the bindless spec to reflect these changes
Fix Vulkan interop tests to prevent memory leak issue by freeing mapped memory
Corresponding UR PR: oneapi-src/unified-runtime#1351
Depends on #12784 merging first