[SYCL][NATIVECPU] Move pipeline creation to CodeGen #12854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
This was referenced Feb 28, 2024
bader
changed the title
| @@ -1087,6 +1087,10 @@ void EmitAssemblyHelper::RunOptimizationPipeline( | |||
|
|
|||
| if (SYCLNativeCPUBackend) { | |||
| llvm::sycl::utils::addSYCLNativeCPUBackendPasses(MPM, MAM, Level); | |||
| // Run optimization passes after all the changes we made to the kernels. | |||
| // Todo: maybe we could find a set of relevant passes instead of re-running | |||
There was a problem hiding this comment.
Nit: TODO s are usually capitalized.
uwedolinsky
approved these changes
Feb 28, 2024
| // Run optimization passes after all the changes we made to the kernels. | ||
| // Todo: maybe we could find a set of relevant passes instead of re-running | ||
| // the full optimization pipeline. | ||
| MPM.addPass(PB.buildPerModuleDefaultPipeline(Level)); |
There was a problem hiding this comment.
Minor (Does not block the PR): It could perhaps be helpful to mention in the comment that the invocation of the pipeline had to be moved into core clang because in the original place in SYCLLowerIR it introduces a circular dependency that causes problems when building as shared library.
AlexeySachkov
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes post commit failure from #12659.