[SYCL] Rewrite image_api LIT as Google Unit test #1294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 10, 2020 14:31
Avoids usage of private APIs in end-to-end tests, places a scheduler test alongside its siblings. Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
…e_api_test * origin/sycl: [SYCL][NFC] Fix static code analysis concerns (intel#1283) [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277) [SYCL][CUDA] Implement the program kernel names query (intel#1248) [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261) [SYCL][UX] Diagnostic for undefined device functions (intel#1026) [SYCL] Reverse reqd_work_group_size attribute (intel#1234) [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249) [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129)
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
…e_api_test * origin/sycl: [SYCL] Implement thread-local storage restriction (intel#1281) [Driver][SYCL][FPGA] Adjust the output location for the project report (intel#1278)
added 5 commits
March 17, 2020 11:23
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
…e_api_test * origin/sycl: (1188 commits) [SYCL][CUDA] Improve CUDA backend documentation (intel#1293) [SYCL] Emit textual IR when -S -fsycl-device-only is used (intel#1314) [SYCL] Add prototype of group algorithms (intel#1236) [SYCL] XFAIL test on windows to unblock pulldown Allow Intel Loop Controls only with SPV_INTEL_fpga_loop_controls Apply suggested assert msg change Implement SPV_INTEL_io_pipes extension [SYCL] Fix dependencies for SYCLLowerIR (intel#1321) [CI] Allow builds without pre-downloaded OpenCL in configure.py (intel#1317) [SYCL] Move SYCL headers from standard clang location (intel#1308) [mlir] Add support for generating dialect declarations via tablegen. Be more strict when checking existence of foo [CodeGenPrepare] Freeze condition when transforming select to br [ORC] Remove an undefined static method from LLJIT. [JITLink][AArch64] Fix incorrect capitalization in a testcase name. [ORC] Print symbol flags and materializer name in ExecutionSession::dump. [JITLink][MachO] Re-apply b64afad, MachO linker-private support, with fixes. Basic Block Sections Support. Test commit. [SYCL][Doc] Deploy documentation for PI (intel#1318) ...
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
romanovvlad
requested changes
Mar 18, 2020
|
|
||
| auto CGHLambda = [&](MockHandler &CGH) { | ||
| auto SrcAcc = | ||
| SrcImg.template get_access<sycl::float4, sycl::access::mode::read>(CGH); |
There was a problem hiding this comment.
I'm not sure this test makes sense when it doesn't use internal API.
Why can't we continue using internal API in google tests?
And if we cannot, I suggest removing the test completely.
There was a problem hiding this comment.
By "use internal API" do you mean creating accessor directly inside the handler?
I think it is a duplication of code. And if the logic inside the handler changes a bit, this test will become invalid (yet it still may pass). Do we need such a test?
|
Replaced with #1349 |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
Complementary change to intel#6890.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids usage of private APIs in end-to-end tests, places a scheduler
test alongside its siblings. Also fixes a few warnings revealed by
this refactoring.
Signed-off-by: Alexander Batashev alexander.batashev@intel.com