-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][DeviceSanitizer] Support GPU DG2 Device #13450
Conversation
Co-authored-by: Wenju He <wenju.he@intel.com>
6f35ab7
to
86e5553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UR LGTM
@intel/llvm-gatekeepers could this merge? The failures are the same as reported in #14715. |
@AllanZyne - Following this PR a lot of address sanitizer tests started failing in post-commit on DG2:
Can you please let us know if it is a simple fix or whether we'll have to revert this patch? |
#14720 (comment) is suggesting to add |
Following the merge of intel#13450 there were reports of failures on PVC: * intel#14720 (comment) * intel#13450 (comment) This patch the suggestion in intel#14720 (comment) to disable AddressSanitizer testing on PVC devices.
@AllanZyne which part of this PR requires gpu driver uplift as mentioned in #14720 (comment)? |
Following the merge of intel#13450 there were reports of failures on PVC & DG2: * intel#14720 (comment) * intel#13450 (comment) This patch the suggestion in intel#14720 (comment) to disable AddressSanitizer testing on PVC & DG2 devices.
Following the merge of #13450 there were reports of failures on PVC & DG2: * #14720 (comment) * #13450 (comment) This patch the suggestion in #14720 (comment) to disable AddressSanitizer testing on PVC & DG2 devices.
UR: oneapi-src/unified-runtime#1521 - Add MemToShadow_DG2 - Enable lit tests for GPU, decrease the global workgoup size in some tests due to the limit of GPU memory Although, the "_DG2" suffix might be misleading: DG2 present all 48bits virtual address devices, and PVC present all 58bits virtual address devices. --------- Co-authored-by: Wenju He <wenju.he@intel.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Following the merge of intel#13450 there were reports of failures on PVC & DG2: * intel#14720 (comment) * intel#13450 (comment) This patch the suggestion in intel#14720 (comment) to disable AddressSanitizer testing on PVC & DG2 devices.
) A simple typo introduced in #13450 Was causing false-positive `[kernel] Private shadow memory out-of-bound` errors.
UR: oneapi-src/unified-runtime#1521
Although, the "_DG2" suffix might be misleading: DG2 present all 48bits virtual address devices, and PVC present all 58bits virtual address devices.