Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][DeviceSanitizer] Support GPU DG2 Device #13450

Merged
merged 38 commits into from
Jul 24, 2024
Merged

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Apr 17, 2024

UR: oneapi-src/unified-runtime#1521

  • Add MemToShadow_DG2
  • Enable lit tests for GPU, decrease the global workgoup size in some tests due to the limit of GPU memory

Although, the "_DG2" suffix might be misleading: DG2 present all 48bits virtual address devices, and PVC present all 58bits virtual address devices.

libdevice/sanitizer_utils.cpp Outdated Show resolved Hide resolved
libdevice/sanitizer_utils.cpp Show resolved Hide resolved
Co-authored-by: Wenju He <wenju.he@intel.com>
@AllanZyne AllanZyne requested a review from a team as a code owner April 18, 2024 07:51
@AllanZyne AllanZyne marked this pull request as draft April 18, 2024 08:02
@AllanZyne AllanZyne changed the title [DeviceSanitizer] Support GPU DG2 Device [DeviceSanitizer][NOT-READY-FOR-REVIEW] Support GPU DG2 Device Apr 18, 2024
@AllanZyne AllanZyne changed the title [DeviceSanitizer][NOT-READY-FOR-REVIEW] Support GPU DG2 Device [SYCL][DeviceSanitizer][NOT-READY-FOR-REVIEW] Support GPU DG2 Device Apr 18, 2024
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR LGTM

@kbenzie
Copy link
Contributor

kbenzie commented Jul 24, 2024

@intel/llvm-gatekeepers could this merge? The failures are the same as reported in #14715.

@martygrant martygrant merged commit 450683b into sycl Jul 24, 2024
13 of 15 checks passed
@martygrant martygrant deleted the review/yang/dg2 branch July 24, 2024 16:03
@steffenlarsen
Copy link
Contributor

@AllanZyne - Following this PR a lot of address sanitizer tests started failing in post-commit on DG2:

  SYCL :: AddressSanitizer/common/demangle-kernel-name.cpp
  SYCL :: AddressSanitizer/common/kernel-debug.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-int.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-long.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-short.cpp
  SYCL :: AddressSanitizer/multiple-reports/multiple_kernels.cpp
  SYCL :: AddressSanitizer/multiple-reports/one_kernel.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global_image_scope.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global_image_scope_unaligned.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/multi_device_images.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_char.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_func.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_int.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_short.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_no_local_size.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/unaligned_shadow_memory.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_2d.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_3d.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_copy_fill.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/subbuffer.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/group_local_memory.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/local_accessor_basic.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/local_accessor_function.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/local_accessor_multiargs.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/multiple_source.cpp
  SYCL :: AddressSanitizer/out-of-bounds/private/multiple_private.cpp
  SYCL :: AddressSanitizer/out-of-bounds/private/single_private.cpp

Can you please let us know if it is a simple fix or whether we'll have to revert this patch?

@kbenzie
Copy link
Contributor

kbenzie commented Jul 25, 2024

Can you please let us know if it is a simple fix or whether we'll have to revert this patch?

#14720 (comment) is suggesting to add gpu-intel-pvc to the list of unsupported for the asan lit config.

kbenzie added a commit to kbenzie/llvm that referenced this pull request Jul 25, 2024
Following the merge of intel#13450 there
were reports of failures on PVC:

* intel#14720 (comment)
* intel#13450 (comment)

This patch the suggestion in
intel#14720 (comment) to
disable AddressSanitizer testing on PVC devices.
@wenju-he
Copy link
Contributor

@AllanZyne which part of this PR requires gpu driver uplift as mentioned in #14720 (comment)?

kbenzie added a commit to kbenzie/llvm that referenced this pull request Jul 25, 2024
Following the merge of intel#13450 there
were reports of failures on PVC & DG2:

* intel#14720 (comment)
* intel#13450 (comment)

This patch the suggestion in
intel#14720 (comment) to
disable AddressSanitizer testing on PVC & DG2 devices.
sarnex pushed a commit that referenced this pull request Jul 25, 2024
Following the merge of #13450 there
were reports of failures on PVC & DG2:

* #14720 (comment)
* #13450 (comment)

This patch the suggestion in
#14720 (comment) to
disable AddressSanitizer testing on PVC & DG2 devices.
hdelan pushed a commit to hdelan/llvm that referenced this pull request Jul 26, 2024
UR: oneapi-src/unified-runtime#1521

- Add MemToShadow_DG2
- Enable lit tests for GPU, decrease the global workgoup size in some
tests due to the limit of GPU memory

Although, the "_DG2" suffix might be misleading: DG2 present all 48bits
virtual address devices, and PVC present all 58bits virtual address
devices.

---------

Co-authored-by: Wenju He <wenju.he@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
hdelan pushed a commit to hdelan/llvm that referenced this pull request Jul 26, 2024
Following the merge of intel#13450 there
were reports of failures on PVC & DG2:

* intel#14720 (comment)
* intel#13450 (comment)

This patch the suggestion in
intel#14720 (comment) to
disable AddressSanitizer testing on PVC & DG2 devices.
martygrant pushed a commit that referenced this pull request Aug 12, 2024
)

A simple typo introduced in #13450

Was causing false-positive `[kernel] Private shadow memory out-of-bound`
errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants