Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Track disabled E2E Tests #14475

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Jul 8, 2024

Improve tracking of disabled E2E tests by providing a link to GitHub issue where the bug is tracked, or explicitly mentioning that a skip is intended, i.e. Due to a known limitation external to the SYCL RT.

See the OpenCL section of the SYCL-Graph design doc as to why a large number of tests are intended skips on the OpenCL backend.

Unsupported SYCL-Graph tests currently fall into 3 categories:

Improve tracking of disabled E2E tests by providing
a link to GitHub issue where bug is tracker, or explicitly
mentioning that a skip is intended, i.e. Due to a known limitation
external to the SYCL RT.

See the [OpenCL
section](https://github.com/intel/llvm/blob/sycl/sycl/doc/design/CommandGraph.md#opencl)
of the SYCL-Graph design doc as to why a large number of tests
are intended skips on the OpenCL backend.

Unsupported SYCL-Graph tests currently fall into 3 categories:
* [Flaky Windows tests](intel#11852)
* [Arc fails](intel#14474)
* [host-task leaks when using with L0 immediate
  command-lists](intel#14473)
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @EwanC !

@EwanC EwanC marked this pull request as ready for review July 9, 2024 07:50
@EwanC EwanC requested a review from a team as a code owner July 9, 2024 07:50
@EwanC
Copy link
Contributor Author

EwanC commented Jul 10, 2024

@intel/llvm-gatekeepers This is good to go, thanks

@sommerlukas sommerlukas merged commit b0f203d into intel:sycl Jul 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants