[SYCL] Fix for alignment requests > 64KB. #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rdeodhar <rajiv.deodhar@intel.com>
| @@ -617,6 +617,10 @@ void *USMAllocContext::USMAllocImpl::allocate(size_t Size, size_t Alignment) { | |||
| if (Alignment <= 1) | |||
| return allocate(Size); | |||
|
|
|||
| // L0 does not support alignments > 64KB, so we don't either. | |||
| if (Alignment > 65536) | |||
| Alignment = 65536; | |||
There was a problem hiding this comment.
This will silently NOT satisfy the requested alignment. Should we give an error instead?
There was a problem hiding this comment.
I was also debating with myself about that.
What type of error would that be? There is no existing PI_ERROR_ that could be used, other than UNKNOWN.
There was a problem hiding this comment.
We could just use PI_INVALID_VALUE or even create a new PI error code (later will need some design thought how to not overlap with existing errors still based of OpenCL errors).
Signed-off-by: rdeodhar <rajiv.deodhar@intel.com>
smaslov-intel
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change caps alignment of allocation requests at 64KB. That is the default alignment supported by level_zero, and no other alignments are supported.
Signed-off-by: rdeodhar rajiv.deodhar@intel.com